Add login functionality to ezBIDS #101

nicoalee · 2023-10-31T15:14:24Z

This PR aims to connect our login implementation for brainlife to ezBIDS.

NOTE: This PR is also connected to changes to generate_keys.sh.

HOW TO TEST

Go to chrome and enter this flag in the URL: chrome://flags/#block-insecure-private-network-requests . Set it to disabled
- This flag exists due to security vulnerabilities so make sure to enable again after testing
Go to http://149.165.152.76:8080/ezbids/
Click on Get Started and log in
- ADMIN USER: email: [email protected] password: 30q49th
- GUEST USER: email: [email protected] password: 912r3iub
Check that you can go to warehouse projects and are logged in already
create an ezBIDS session by uploading files
    - login as another user in private browsing (you can create a user if you want or use the one you are not logged in with) and check that you cannot access the session
    - in the original window, click the Share Session button to open the manage users dialog and add a user.
    - use incognito mode and log in as the user you just added. Check that you can access the given session. This user should not be able to see the Share Session button.

SUMMARY OF CHANGES

Removed a bunch of auto generated .js files
Added implementation for validating JWTs in auth.ts.
    - ezBIDS now issues its own JWTs from the /download/:session_id/token which will only be valid for 10 seconds.
    - The reason for this is because the /download/:session_id/* route often is used in a way that does not allow us to attach HTTP headers. We therefore send a JWT in the URL (albeit a short lived one).
    - The /download/:session_id/* route is the only valid route that expects and consumes these JWTs. Other routes will expect JWTs in the header.
All API routes now are protected except for the healthcheck
dev.sh has been modified to be clearer on failure
A ManageUsersDialog has been added in order to add/remove users to the session to share it with them. It can only be shared with other brainlife users
Note: We use the same JWTs received from the auth service as warehouse. This means that if someone logs into warehouse, they can access ezBIDS and vice versa.
A bunch of <a ...><img ... /></a> HTML has been replaced with a custom <AsyncImageLink />. This is because of the previously mentioned token change.
- previously these elements were bound to the path directly, i.e. <img :src="/route/to/backend.png" />. This doesn't work anymore so this case needs to be handled.
I've replaced all fetch requests with axios. Axios allows us to add a global http interceptor, which I've defined in axios.instance.ts. This attaches a JWT to every outgoing request.
I've added route protections to prevent people from navigating to /ezbids/convert unless they are authenticated
The manage session button only appears if (1) there is a session and (2) the owner of the session is the current user.
- people added to the session cannot add more users, only the owner can

…me port

…r users

dlevitas · 2023-11-07T18:32:38Z

LGTM, based on your testing instructions.

anibalsolon

LGTM some minor things but not obstructing

anibalsolon · 2023-10-31T15:26:06Z

.gitignore

+
+api/*.pub
+api/*.key
+api/ezbids.key


I guess the previous line should account for ezbids.key

api/models.ts

anibalsolon · 2023-11-01T20:35:18Z

ui/src/LandingPageHeader.vue

+                                style="font-size: var(--el-font-size-extra-large); font-family: unset; color: #3482e9;"
+                                >{{ hasJWT ? "GET STARTED" : "LOG IN / REGISTER"}}</el-button
+                            >
+                            <!-- <RouterLink style="text-decoration: none;" to="/convert">LOG IN / REGISTER</RouterLink> -->


safe to cleanup

anibalsolon · 2023-11-01T20:36:08Z

ui/src/Upload.vue

-
-                <br>
-                <br>
-                <br>
+


anibalsolon · 2023-11-01T20:37:11Z

ui/src/Upload.vue

+                    Uploading
+                    <font-awesome-icon icon="spinner" pulse/>
+                </h3>
+                <small>Please do not close/refresh this page until all files are uploaded.</small>


For semantics I'd still wrap with a block element, like <p>

i removed this originally because i was getting template parsing errors:

anibalsolon · 2023-11-01T20:38:34Z

ui/src/Upload.vue

+            const res = await axios.post(`${this.config.apihost}/session`, {
+                headers: { 'Content-Type': 'application/json' }
+            })
+            console.log("created new session");


im going to hold off on this for now, as cleaning this up will mean redoing how we manage configs in ezBIDS. (currently we store them in the store, which is quite annoying if we want to access them outside of the vuex context)

anibalsolon · 2023-11-07T20:53:29Z

api/controllers.ts

        next(err);
    });
 });

-router.post('/upload-multi/:session_id', upload.any(), (req:any, res, next)=>{
+router.post('/upload-multi/:session_id', validateWithJWTConfig(), upload.any(), (req: any, res, next) => {
+    userCanAccessSession(req.params.session_id, req.auth.sub as unknown as number, false).then(async (session) => {


couldnt userCanAccessSession be a router middleware?

done, the req object will now hold a property ezBIDS which contains the session

anibalsolon · 2023-11-07T21:06:51Z

ui/src/components/dialogs/ManageUsersDialog.vue

+                            size="large"
+                            closable
+                            v-for="allowedUser in allowedUserProfiles"
+                            :key="allowedUser?.sub"


for some reason, github highlighting breaks at this point, I think it does not understand the ?. yet

Based on my testing, this should be fine

dlevitas · 2023-11-10T15:15:54Z

@nicoalee feel free to merge this PR after looking over Anibal's comments

Ubuntu added 10 commits October 10, 2023 21:06

feat: remove map files

b5eab24

fix: removed unnecessary js files and added better error handling

d219e16

fix: added wait for healthcheck

5f9dec9

fix: remove vue-router

f5efe74

test: playing around with configs to get auth and ezbids hosted on sa…

46e8e88

…me port

feat: adding ui changes to allow login and sharing sessions with othe…

e15a684

…r users

feat: added UI implementation and BE route protections for ezbids auth

622c2c3

feat: added login and jwt handling

ca35d43

feat: fixed up minor bugs, updated download for finalize component

07f3183

feat: removed testing comments

f40ab26

nicoalee requested review from anibalsolon, bhatiadheeraj and dlevitas October 31, 2023 15:14

Merge branch 'master' into BTP-22-update-ezBIDS-add-auth

8a8a3d0

nicoalee self-assigned this Oct 31, 2023

feat: fixed redirect and added docker-compose connection str

5f23aef

bhatiadheeraj removed their request for review November 1, 2023 16:35

dlevitas approved these changes Nov 7, 2023

View reviewed changes

anibalsolon approved these changes Nov 7, 2023

View reviewed changes

nicoalee added 4 commits November 13, 2023 14:14

feat: merged in master and updated styling

fa90a58

feat: update styling and addressing PR comments

3234535

feat: refactored code based on suggestions

f277836

chore: resolve merge conflict

f501e01

nicoalee merged commit c45846b into brainlife:master Nov 14, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add login functionality to ezBIDS #101

Add login functionality to ezBIDS #101

nicoalee commented Oct 31, 2023 •

edited

Loading

dlevitas commented Nov 7, 2023

anibalsolon left a comment

anibalsolon Oct 31, 2023

anibalsolon Nov 1, 2023

nicoalee Nov 14, 2023

anibalsolon Nov 1, 2023

anibalsolon Nov 1, 2023

nicoalee Nov 13, 2023

anibalsolon Nov 1, 2023

nicoalee Nov 13, 2023 •

edited

Loading

anibalsolon Nov 7, 2023

nicoalee Nov 14, 2023 •

edited

Loading

anibalsolon Nov 7, 2023

nicoalee Nov 14, 2023

dlevitas commented Nov 10, 2023

Add login functionality to ezBIDS #101

Add login functionality to ezBIDS #101

Conversation

nicoalee commented Oct 31, 2023 • edited Loading

This PR aims to connect our login implementation for brainlife to ezBIDS.

HOW TO TEST

SUMMARY OF CHANGES

dlevitas commented Nov 7, 2023

anibalsolon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicoalee Nov 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicoalee Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlevitas commented Nov 10, 2023

nicoalee commented Oct 31, 2023 •

edited

Loading

nicoalee Nov 13, 2023 •

edited

Loading

nicoalee Nov 14, 2023 •

edited

Loading