Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nginx forwarding #133

Closed

Conversation

bendhouseart
Copy link
Contributor

@bendhouseart bendhouseart commented Sep 18, 2024

This adds nginx forwarding so that a local/on-prem deployment can behave a bit better.

TODO:

  • Set up redirects and forwarding so that /ezbids takes you to the expected place
  • Configure nginx to accept ssl certs and use HTTPS when available
  • Realign changes building and installing into docker images from Mac

@dlevitas I had to mess with vite and some other changes you recently made to make this behave on Mac, I'm not sure if it's worth adding in some logic to use/not use parts of the config if it's being built on Mac at all. In all honesty, it's probably best to undo those changes, but idk.

Comment on lines -20 to +21
(cd api && npm install -g [email protected])
(cd ui && npm install -g [email protected])
(cd api && npm install)
(cd ui && npm install)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlevitas @anibalsolon Mac is such a nightmare, I had to mess with this stuff and disable husky to get this running on my x86 machine (old intel mac pro). As I mention in the PR description this should probably be undone, will do so once I've got https working properly.

@bendhouseart
Copy link
Contributor Author

Moving all changes into Tim's PR #134; closing.

@bendhouseart bendhouseart reopened this Oct 17, 2024
@bendhouseart bendhouseart marked this pull request as ready for review October 17, 2024 15:03
@bendhouseart
Copy link
Contributor Author

@anibalsolon @dlevitas Okay, well, this works good enough and is how I'm currently running ezbids at the NIMH. I updated renamed dev.sh to launch.sh, switched over from command line args to the use of a config file (see example.env), and created a second docker compose for production that uses nginx and ssl certs.

I need to spend some more time getting nginx working for http, but I'm tired of trying to make CORS work for that, so I'm humbly giving up for now.

I think I need to update the documentation on RTD to reflect the current changes for self hosting as it's not going to be 100% clear to a user now that I've stripped out dev.sh.

@bendhouseart
Copy link
Contributor Author

Rolled these changes into @buti1021's PR #134 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants