Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Btp 16 add ezbids landing page #94

Merged
merged 11 commits into from
Oct 3, 2023

Conversation

nicoalee
Copy link
Collaborator

@nicoalee nicoalee commented Sep 27, 2023

PR to add new landing page to ezBIDS.

Desktop mode:
image

Mobile mode:
mobile

package.json Outdated
@@ -29,7 +29,8 @@
"nocache": "^2.1.0",
"node-pty": "^0.10.1",
"range-stream": "^1.1.0",
"send-seekable": "^1.0.4"
"send-seekable": "^1.0.4",
"vue-router": "^4.2.5"
Copy link
Collaborator Author

@nicoalee nicoalee Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up added routing because

  1. this felt cleaner. The alternative was to add a component to the App.vue file and then programmatically check if the store page === 'landingpage'. If page === 'landingpage' then I'd have to hide the <aside /> and programmatically remove all the <aside /> related CSS. Not impossible by any means but annoying and not clean.
  2. we probably want routing in the future. Someone should be able to visit the URL and continue editing from where they left off, or they should be able to send their draft to someone else. In order to do this, we would want some sort of ezBIDS url like https://brainlife.io/ezbids/subject#sessionid=abc123 or https://brainlife.io/ezbids/finalize#sessionid=abc123

ui/src/App.vue Outdated
Copy link
Collaborator Author

@nicoalee nicoalee Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved all this to BaseConvertPage.vue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this is from App.vue. I did not change any of the actual code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: most of the contents of this file is just SVG related stuff, generated in figma.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the code has been changed, i just moved the <template></template> stuff to the top in order to make it aligned with the other .vue files

ezBIDS requires neither coding proficiency nor knowledge of BIDS in
order to get started. It is the first BIDS tool to offer guided
standardization, support for task events conversion, and
interoperability with OpenNeuro and brainlife.io.
Copy link
Collaborator

@dlevitas dlevitas Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicoalee Let's provide links to OpenNeuro and brainlife, e.g.:

interoperability with <a href="https://openneuro.org/" target="_blank" >OpenNeuro</a> and <a href="https://brainlife.io/about/" target="_blank" >brainlife.io</a>.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@nicoalee nicoalee merged commit 846c50f into brainlife:master Oct 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants