-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Btp 16 add ezbids landing page #94
Btp 16 add ezbids landing page #94
Conversation
package.json
Outdated
@@ -29,7 +29,8 @@ | |||
"nocache": "^2.1.0", | |||
"node-pty": "^0.10.1", | |||
"range-stream": "^1.1.0", | |||
"send-seekable": "^1.0.4" | |||
"send-seekable": "^1.0.4", | |||
"vue-router": "^4.2.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up added routing because
- this felt cleaner. The alternative was to add a component to the App.vue file and then programmatically check if the store
page === 'landingpage'
. Ifpage === 'landingpage'
then I'd have to hide the<aside />
and programmatically remove all the<aside />
related CSS. Not impossible by any means but annoying and not clean. - we probably want routing in the future. Someone should be able to visit the URL and continue editing from where they left off, or they should be able to send their draft to someone else. In order to do this, we would want some sort of ezBIDS url like
https://brainlife.io/ezbids/subject#sessionid=abc123
orhttps://brainlife.io/ezbids/finalize#sessionid=abc123
ui/src/App.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved all this to BaseConvertPage.vue
ui/src/BaseConvertPage.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this is from App.vue
. I did not change any of the actual code
ui/src/LandingPageAnimation.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: most of the contents of this file is just SVG related stuff, generated in figma.
ui/src/Upload.vue
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
none of the code has been changed, i just moved the <template></template>
stuff to the top in order to make it aligned with the other .vue files
ui/src/LandingPageContent.vue
Outdated
ezBIDS requires neither coding proficiency nor knowledge of BIDS in | ||
order to get started. It is the first BIDS tool to offer guided | ||
standardization, support for task events conversion, and | ||
interoperability with OpenNeuro and brainlife.io. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicoalee Let's provide links to OpenNeuro and brainlife, e.g.:
interoperability with <a href="https://openneuro.org/" target="_blank" >OpenNeuro</a> and <a href="https://brainlife.io/about/" target="_blank" >brainlife.io</a>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
PR to add new landing page to ezBIDS.
Desktop mode:
Mobile mode: