-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snirf] Improve support to SNIRF #756
base: master
Are you sure you want to change the base?
[snirf] Improve support to SNIRF #756
Conversation
@rcassani what would be the best way to handle the optional flag "coordinateSystem" ? Notably, if it is "MNI152NLin2009bAsym" then we need to convert the coordinates from MNI to SCS ? I guess we should already have some function comming from the BIDS import to dead with that. |
@Edouard2laire, this is where the magic from MNI space to Subject space happens: brainstorm3/toolbox/io/import_channel.m Lines 376 to 377 in 85f367a
|
yes; but this function is not called when doing import_data_snirf; right ? since the channel is defined during the import of the data ? |
(maybe we should just throw error for wrongly formated files)
ok. i think the code is much cleaner now. @rcassani, do you think you could help me fill the gap here: % Read coordinate system
if isfield(jnirs.nirs.probe, 'coordinateSystem') && ~isempty(jnirs.nirs.probe.coordinateSystem)
warning('Todo: apply coordinate system');
end
|
This PR adds support for the new measurement list (added in v1.1) and overall provides better support to the SNIRF specifications
The snirf specification can be found here: https://github.com/fNIRS/snirf/blob/master/snirf_specification.md
Todo:
Reading SNIRF :
Writting snirf :
Once all the todo are done; we should be fairly complient with the snirf standard.