-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contactPreference to PayPalCheckoutRequest #1280
base: main
Are you sure you want to change the base?
Conversation
DO NOT MERGE until end to end testing is completed. |
PayPal/src/test/java/com/braintreepayments/api/paypal/PayPalCheckoutRequestUnitTest.java
Outdated
Show resolved
Hide resolved
PayPal/src/test/java/com/braintreepayments/api/paypal/PayPalCheckoutRequestUnitTest.java
Show resolved
Hide resolved
@@ -63,6 +63,8 @@ import org.json.JSONObject | |||
* at this URL. | |||
* | |||
* @property contactInformation Contact information of the recipient for the order | |||
* | |||
* @property contactPreference Preference for the contact information section within the payment flow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include something like "if not set, the contact information section will be disabled in the payment flow"? That's the behavior we see if we don't pass this param at all right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, on the API side the enum will default to NO_CONTACT_INFO
if no value is passed in. I've updated the doc string.
CHANGELOG.md
Outdated
## unreleased | ||
|
||
* PayPal | ||
* Add `contactPreference` property to `PayPalCheckoutRequest` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we think it's worth calling this out as a bug fix as well? Merchants will need to be on this version to use contact module or will the GW be defaulting a value. cc: @sarahkoop my brain is fuzzy with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not sure how we'd want to spin it. I guess the contact section would never show up without this new param. Do we know how it was communicated to merchants trying to integrate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Add
contactPreferenceproperty to
PayPalCheckoutRequest - This property is required to enable the contact information section in the payment flow.
Summary of changes
contactPreference
param toPayPalCheckoutRequest
SHOPPER_SESSION_ID
toSHOPPER_SESSION_ID_KEY
to match naming conventionChecklist
Authors