[INF-178 follow-up] Plan-mode terraform test for unset license key - #308
Open
Erik Weathers (erikdw) wants to merge 1 commit into
Open
Conversation
4 tasks
Erik Weathers (erikdw)
force-pushed
the
erikdw/inf-178-license-null-terraform-test
branch
from
July 31, 2026 00:33
f0ea6ab to
e6580a8
Compare
validate cannot catch coalesce(null, "") style regressions because it treats variables as unknown. Add a mocked terraform test with command = plan, wire mise run test / test-tofu into CI, and document the validate vs test distinction. Co-authored-by: Cursor <cursoragent@cursor.com>
Erik Weathers (erikdw)
force-pushed
the
erikdw/inf-178-license-null-terraform-test
branch
from
July 31, 2026 00:33
e6580a8 to
c093960
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brainstore_license_key = null.terraform validatedoes not catchcoalesce(null, "")(variables stay unknown); this usesterraform testwithcommand = planand mocked providers.mise run test/mise run test-tofuinto Terraform CI.Stacked on #307 (
erikdw/ecs-ec2-secrets-from-sm).https://linear.app/braintrustdata/issue/INF-178
Test plan
mise run testpasses on this branchcoalesce(var.brainstore_license_key, "")local restored locally,mise run testfailsMade with Cursor