Default ECS quarantine proxy to CloudFront hairpin - #321
Draft
Erik Weathers (erikdw) wants to merge 1 commit into
Draft
Default ECS quarantine proxy to CloudFront hairpin#321Erik Weathers (erikdw) wants to merge 1 commit into
Erik Weathers (erikdw) wants to merge 1 commit into
Conversation
Split the API ECS ALB into its own module so QUARANTINE_PROXY_URL can use ingress.api_url without a Terraform cycle. With enable_ecs_api, quarantine defaults to the dataplane public /v1/proxy (custom_domain preferred); quarantine_proxy_url remains an explicit override for hosted gateway etc. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modules/api-ecs-alb(withmovedblocks) so tasks can bakeingress.api_urlintoQUARANTINE_PROXY_URLwithout a Terraform cycle.enable_ecs_apiis on, quarantine LLM calls default to the dataplane public/v1/proxyCloudFront hairpin (custom_domainpreferred, else*.cloudfront.net), instead of hostedgateway.braintrust.dev.quarantine_proxy_urloverride for hosted gateway / custom URLs.Test plan
terraform planon an existing ECS dataplane: ALB resources show as moves (not destroy/create)QUARANTINE_PROXY_URLon API ECS ishttps://<custom_domain|cloudfront>/v1/proxy/v1/proxy(not hosted gateway)quarantine_proxy_url = "https://gateway.braintrust.dev/v1/proxy"and confirm env flipsMade with Cursor