Repository navigation
Feat/windows support - #49
Open
jonathansampson wants to merge 8 commits into
Open
jonathansampson wants to merge 8 commits into
jonathansampson wants to merge 8 commits into
Conversation
Author
Windows renders the built-in Administrator's SID as the alias LA, and the GitHub Windows runner runs as that account, so comparing a file's rendered access list against the raw SID failed only in CI. Render the expected list through the same conversion so both sides use the same aliases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds Windows 10 and 11 support. The app now builds, runs and packages on Windows, and the file helper applies the same safety rules there.
unix.rs(unchanged behavior) and a newwindows.rs. On Windows, each file is opened one folder at a time, starting from a folder that is already open, usingNtCreateFile. A project can be on a drive or a network share.:, which would open a separate data stream.mode: 0o600on Windows, so drafts and memory history are written through the helper there.C:\...) or share path (\\server\share\...). Relative paths use/across IPC, and on Windows a\or:in them is refused.build-bridge.shis replaced bybuild-bridge.mjs, so building no longer needs a Unix shell. On Windows the app looks for its helper binaries with.exe.npm run packagemakesdist\Brave Bot-win32-<arch>\(unsigned, no installer). Both crates embed anasInvokermanifest in MSVC builds, so Windows doesn't block binaries whose names contain words likesetuporpatch.cargo test --all.Known limitations
Projects on a network share only. These don't affect projects on a local drive. They apply when a project is stored on a network share, whether it's opened through a mapped drive letter or a
\\server\sharepath.C:\Windows(upstream). The agent turns a network project's path into a UNC path, andcmd.execan't use a UNC path as its working folder. Socmdand batch files the agent runs, such asnpm.cmd, start inC:\Windows. Programs it runs directly, likenodeorgit, start in the project folder as expected. The fix belongs in the agent.Tests. The helper's tests make symlinks, which needs Developer Mode or an admin shell. Without either, they fail instead of skipping. The network-share test runs only when asked:
cargo test -p bravebot-ui-files -- --ignored.A separate change will move absolute-path parsing out of shared and renderer code.
Test plan
cargo test -p bravebot-ui-files -- --include-ignored, plus Clippy for that cratescripts/*.test.mjs) andtsc --noEmitcargo test --allnpm run dev, then open aC:\project, preview and attach a file, and save a draftnpm run package, thennpm run drive:smoke -- "dist\Brave Bot-win32-x64\Brave Bot.exe"