Repository navigation
Do not pass the claude model alias to a bravebot review session - #215
Merged
Merged
Conversation
review-agent.sh handed BOT_REVIEW_MODEL (default 'sonnet') to bravebot as --model. bravebot resolves that to a Brave model and exits with BB1003 when the operator has a service of their own configured, so every scheduled review and ping reply failed before it started. Use bot.bravebotModel, or nothing, so bravebot's own model setting applies.
bbondy
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
reviewer.agentset tobravebot, every scheduled review and ping reply died before it started:scripts/lib/review-agent.shpassedBOT_REVIEW_MODEL(defaultsonnet, a claude alias) to bravebot as--model sonnet. bravebot resolves that to a Brave model and refuses it when the operator has a service of their own. brave/bravebot#3832 and #3833 hit it 5 times each and were then skipped by the attempt cap.Reproduce
~/.bravebot/settings.json:bravebot "say ok" --model sonnetfails with BB1003.bravebot "say ok"printsok.Fix
The bravebot branch of
bot_review_agent_cmdignores the claude alias. It passes--modelonly whenbot.bravebotModelis set, so otherwise bravebot's ownmodelsetting applies. The claude branch is unchanged. Documented indocs/configuration.md.Tests
tests/test_agent_config.pygains a test: no--modeland nosonnetby default, andmy-modelwhenBOT_BRAVEBOT_MODELis set. Full suite: 1701 passed, 4 skipped.