Skip to content

kafka with iam msk#1693

Closed
husobee wants to merge 2 commits intomasterfrom
iam-msk
Closed

kafka with iam msk#1693
husobee wants to merge 2 commits intomasterfrom
iam-msk

Conversation

@husobee
Copy link
Copy Markdown
Contributor

@husobee husobee commented Nov 7, 2022

Summary

up kafka-go to 0.4.36

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee requested a review from hspencer77 November 7, 2022 19:27
@husobee husobee self-assigned this Nov 7, 2022
hspencer77
hspencer77 previously approved these changes Nov 7, 2022
Copy link
Copy Markdown
Contributor

@hspencer77 hspencer77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants