Fix the no_std build #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `alloc` crate is always available in rust 1.36 and later, so we don't need a special feature flag to enable it. Instead, enable the `curve25519-dalek/alloc` feature unconditionally and rely on building with `--no-default-features` to disable standard library dependence. Restores building and running tests in a no_std environment.
Add a continuous integration job to confirm the no_std build is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if this is helpful or not. I noticed some breakage with different feature flags, which lead to this cleanup, but didn't know how to test with any wasm targets so I don't know if that target was actually broken or is different now.
allocfeature; the crate is now always available in stable rust, so we don't need a feature flag to request it.curve25519-dalek/allocunconditionally since dleq uses the multiscalar_mul unconditionally.--no-default-featuresworks.Anyway, these changes made the behaviour less surprising for me, so please consider.