Skip to content

Add page visibity detection checks#220

Open
ryanbr wants to merge 1 commit into
masterfrom
add-pageview
Open

Add page visibity detection checks#220
ryanbr wants to merge 1 commit into
masterfrom
add-pageview

Conversation

@ryanbr

@ryanbr ryanbr commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator

@deeppandya wanted specific list for page visibility checks (address brave/brave-browser#38910)

Existing rules will be taken out of brave-specific.txt and experimental.txt when this lands.

Updated pems in 1pass.

brave@localhost:~/adblock-resources$ ./generate_component.sh
Generating values to use in new component defined in list_catalog.json

uuid: bfcf9a6a-e4ed-4ad1-a7d6-3277abe924ca

base64 public key: MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAm/gF6C8WsoBoK+ZQMmJNnu2uhjPuytmCPBx0Np1D/SFDBcWb2FEgYO6X4KmYke2iVKtoB8+Nxrm2axjcJ/PuW+oqOXURGqu5cOtRZfqiII4WTp+/BIUWa4l6xkA+uiIw9qJEqz7j/hR5Z0iz14HggYGs64JqgDsjmvJz0w1U7QXCXrg0NinbcSIdfN/zRiZ+FzRw216DdCgL/NDpNQT8sfsu4v5wY07YphD6jnAEaXLKxRV4q61AKVLoeYtAQyjeotYhDjzftcFFeb9TuRAhDXPfuUxdwKnJoZq7ZaD0Uh59cYl6YfDp26fMxWKqh7hITbVVNNfqAjRXZ/+d40u5vwIDAQAB

component ID: bfpkngdiekaidmngpbajifhmfnjmchac

Private key written to ad-block-updater-bfpkngdiekaidmngpbajifhmfnjmchac.pem.
Please upload it to 1Password and make sure it is synced with Jenkins.
brave@localhost:~/adblock-resources$ ./generate_component.sh
Generating values to use in new component defined in list_catalog.json

uuid: a703bfd7-d777-468d-8295-7644bef61f84

base64 public key: MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAxFgeBtvYzL9eB46+DJ+zAsKwlw31rypoHdDjIpbUwokrofxaDwavOP/5R3NdhHwRGSEvJEWHAN/fCH4qaOJtja63dY+dfHXzNhoEb6a12yOfkfKr8ur8Nzos/RSEHk2tQadllIl5Ef+67Fxx6uUQeDHNhdDF/HEy57aamD+gytKrRl2I4sE/ZS5R7sJjdpObLg/RB6aGJBH971mrIG5YwqJqJsp7MPALCxiihKQUG9LM9NSBvZ6Mcqfm8EaWtcLgAA7CSR6e/vpQerGdnR6QKrIMzInyxwpneu9D/FzvU325c4rtVS3WHgxjFvrvXS3ZzIj40N4mHYqX/HXidjbiaQIDAQAB

component ID: pbahjeaancmjnhaaecahkjokadgndabi

Private key written to ad-block-updater-pbahjeaancmjnhaaecahkjokadgndabi.pem.
Please upload it to 1Password and make sure it is synced with Jenkins.

@ryanbr ryanbr self-assigned this Oct 7, 2024
@github-actions

github-actions Bot commented Oct 7, 2024

Copy link
Copy Markdown

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

},
{
"uuid": "BFCF9A6A-E4ED-4AD1-A7D6-3277ABE924CA",
"title": "Brave pageview Rules",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we settled on title case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants