Yt sabr - cold load issue fix#332
Closed
griffinallen wants to merge 6 commits into
Closed
Conversation
A user reported that every second, the video attempts to reload. A likely cause of this is the fact that we are catching network errors in the readStream and returning "successful" responses. These responses are not what the client expects and it attempts to refetch, causing a loop. Removing this catch should solve this issue.
In response to an issue found with this solution by the AdGuard team. Youtube seems to be enforcing a server-side ad-slot delay. The way to get around this is to force a fresh session the first (and only first) time we find a real backoff from Youtube.
There was an issue with the previous fix where videos would play two times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cold load fix
In response to an issue found with this solution by the AdGuard team. Youtube seems to be enforcing a server-side ad-slot delay. The way to get around this is to force a fresh session the first (and only first) time we find a real backoff from Youtube.