Skip to content

Fixing YT SABR fresh session load issue#334

Merged
ryanbr merged 2 commits into
brave:masterfrom
griffinallen:yt-sabr-fresh-session-fix
Jun 20, 2026
Merged

Fixing YT SABR fresh session load issue#334
ryanbr merged 2 commits into
brave:masterfrom
griffinallen:yt-sabr-fresh-session-fix

Conversation

@griffinallen

@griffinallen griffinallen commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

As discovered by AdGuards team, the original SABR fix did not resolve the video load in all cases. In fact, it would not work at all in AdGuard. This is suspected to be a server side delay enforced, essentially ignoring our patched backoff. To get around this, if we detect the server side delay, we can force a new session with our patched backoff. This will force Youtube to use our patched backoff instead of their server side delay.

Also, the position of the YT Premium check has changed. Before, it was running before the page was fully loaded and would always return false. Now, it runs only when the video starts loading and will return correctly based on the user's Premium status.

As discovered by AdGuards team, the original SABR fix did not resolve the video load in all cases. In fact, it would not work at all in AdGuard. This is suspected to be a server side delay enforced, essentially ignoring our patched backoff. To get around this, if we detect the server side delay, we can force a new session with our patched backoff. This will force Youtube to use our patched backoff instead of their server side delay.
@griffinallen griffinallen requested review from a team and ryanbr June 19, 2026 14:24
The YT premium check now occurs after the page has been fully loaded. Before, it was attempting to check before the DOM was loaded and therefore would always fail. The check now occurs when determining if we need to patch the ad backoff
@ryanbr ryanbr merged commit 9367e41 into brave:master Jun 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants