chore: upgrade eslint-plugin-lingui (#1405)

Which has a number of breaking changes, see https://github.com/lingui/eslint-plugin/releases/tag/0.8.0 This is the change that is breaking #1403.
brave · Dec 3, 2024 · 47c3617 · 47c3617
1 parent 4dcec1c
commit 47c3617
Show file tree

Hide file tree

Showing 12 changed files with 141 additions and 22 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -60,7 +60,26 @@ export default tseslint.config(
       "lingui/no-unlocalized-strings": [
         "error",
         {
-          ignoreAttribute: [
+          ignore: [
+            // Ignore strings which are a single "word" (no spaces)
+            // and doesn't start with an uppercase letter
+            "^(?![A-Z])\\S+$",
+            // Ignore UPPERCASE literals
+            // Example: const test = "FOO"
+            "^[A-Z0-9_-]+$",
+          ],
+          ignoreFunctions: [
+            "createSvgIcon",
+            "log",
+            "useTrackMatomoPageView",
+            "useTrackWithMatomo",
+            "formatInTimeZone",
+            "zonedTimeToUtc",
+            "utcToZonedTime",
+            "graphql",
+            "getGenericMultiSelect",
+          ],
+          ignoreNames: [
             "style",
             "sx",
             "fontFamily",
@@ -74,19 +93,6 @@ export default tseslint.config(
             "gridTemplateRows",
             "gridTemplateAreas",
             "rel",
-          ],
-          ignoreFunction: [
-            "createSvgIcon",
-            "log",
-            "useTrackMatomoPageView",
-            "useTrackWithMatomo",
-            "formatInTimeZone",
-            "zonedTimeToUtc",
-            "utcToZonedTime",
-            "graphql",
-            "getGenericMultiSelect",
-          ],
-          ignoreProperty: [
             "documentTitle",
             "color",
             "border",
@@ -118,6 +124,7 @@ export default tseslint.config(
       "**/*.test.ts",
       "src/components/TimeZonePicker/useTimeZoneList.ts",
       "codegen.ts",
+      "eslint.config.js",
     ],
   },
   {

diff --git a/package.json b/package.json
@@ -79,7 +79,7 @@
     "babel-plugin-macros": "3.1.0",
     "eslint": "8.57.1",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-lingui": "0.7.0",
+    "eslint-plugin-lingui": "0.8.1",
     "eslint-plugin-react": "7.37.2",
     "eslint-plugin-react-hooks": "5.0.0",
     "husky": "9.1.6",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/ErrorBoundary.tsx b/src/ErrorBoundary.tsx
@@ -16,7 +16,6 @@ export class ErrorBoundary extends Component<
 
   static getDerivedStateFromError(error: unknown): State {
     // Update state so the next render will show the fallback UI.
-    console.log("getDerivedStateFromError called", error);
     return { error };
   }
 

diff --git a/src/components/Datagrid/renderers.tsx b/src/components/Datagrid/renderers.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable lingui/no-unlocalized-strings */
 import { Box, Tooltip } from "@mui/material";
 import _ from "lodash";
 import { ReactElement, ReactNode, useContext } from "react";

diff --git a/src/components/Error/ErrorDetail.tsx b/src/components/Error/ErrorDetail.tsx
@@ -49,6 +49,7 @@ export const ErrorDetail = ({ error, additionalDetails }: Props) => {
 
   const stringError = JSON.stringify(error, undefined, 2);
 
+  // eslint-disable-next-line lingui/no-unlocalized-strings
   const errorDetails = `
 URL: ${document.location}
 VERSION: ${VERSION.shortHash}

diff --git a/src/form/DateFieldHelpers.tsx b/src/form/DateFieldHelpers.tsx
@@ -1,5 +1,6 @@
 import dayjs, { Dayjs } from "dayjs";
 
+// eslint-disable-next-line lingui/no-unlocalized-strings
 const ADS_DEFAULT_TIMEZONE = "America/New_York";
 
 export const defaultStartDate = (): string =>

diff --git a/src/index.tsx b/src/index.tsx
@@ -20,6 +20,7 @@ import { useEffect } from "react";
 import { findLocale } from "./i18n";
 
 console.log(
+  // eslint-disable-next-line lingui/no-unlocalized-strings
   `https://github.com/brave/ads-ui rev ${VERSION.shortHash} built ${VERSION.buildTime}`,
 );
 

diff --git a/src/user/User.tsx b/src/user/User.tsx
@@ -94,6 +94,7 @@ export default function User() {
             flex={1}
             component="main"
             marginTop="64px"
+            // eslint-disable-next-line lingui/no-unlocalized-strings
             height="calc(100% - 64px)"
             overflow="auto"
             padding={1}

diff --git a/src/user/reporting/csv.library.tsx b/src/user/reporting/csv.library.tsx
@@ -101,6 +101,7 @@ async function transformConversionEnvelope(blob: Blob): Promise<Blob> {
         Papa.parse(text, {
           header: true,
           transform(value: string, field: string) {
+            // eslint-disable-next-line lingui/no-unlocalized-strings
             if (field.includes("Conversion")) {
               const { ciphertext, nonce, epk }: Envelope = JSON.parse(value);
               const res = tweetnacl.box.open(

diff --git a/src/user/views/user/search/CreateSearchCampaign.tsx b/src/user/views/user/search/CreateSearchCampaign.tsx
@@ -107,6 +107,7 @@ export function CreateSearchCampaign({ domain }: Props) {
             <CardContainer
               childSx={{
                 width: "800px",
+                // eslint-disable-next-line lingui/no-unlocalized-strings
                 height: "calc(100vh - 110px)",
               }}
             >

diff --git a/src/util/billingType.ts b/src/util/billingType.ts
@@ -10,6 +10,7 @@ export function uiLabelsForBillingType(
   billingType: string | undefined | null,
 ): BillingTypeLabels {
   if (!billingType) {
+    // eslint-disable-next-line lingui/no-unlocalized-strings
     return { value: "N/A", shortLabel: "N/A", longLabel: t`Unknown` };
   }