Skip to content

Add all Leo skia colors to light and dark color mixers#19440

Closed
petemill wants to merge 1 commit into
masterfrom
leo-color-mixer
Closed

Add all Leo skia colors to light and dark color mixers#19440
petemill wants to merge 1 commit into
masterfrom
leo-color-mixer

Conversation

@petemill

Copy link
Copy Markdown
Member

This makes referring to the colors from UI classes easier by not having to redefine a new variable with a leo dark or light equivalent. It takes advantage of the fact that all Leo colors already have light and dark equivalents. UI that wishes to have different Leo colors for light and dark can and will still need to specify that explicitly.

Requires brave/leo#343

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This makes referring to the colors from UI classes easier by not having to redefine a new variable with a leo dark or light equivalent. It takes advantage of the fact that all Leo colors already have light and dark equivalents. UI that wishes to have different Leo colors for light and dark can and will still need to specify that explicitly.

@sangwoo108 sangwoo108 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍 Thanks!

@bsclifton

Copy link
Copy Markdown
Member

Closing as stale. Let's rebase branch and create a new PR if this is something we'd still like to pursue. Thanks! 😄

@bsclifton bsclifton closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants