Add all Leo skia colors to light and dark color mixers#19440
Closed
petemill wants to merge 1 commit into
Closed
Conversation
This makes referring to the colors from UI classes easier by not having to redefine a new variable with a leo dark or light equivalent. It takes advantage of the fact that all Leo colors already have light and dark equivalents. UI that wishes to have different Leo colors for light and dark can and will still need to specify that explicitly.
Member
|
Closing as stale. Let's rebase branch and create a new PR if this is something we'd still like to pursue. Thanks! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes referring to the colors from UI classes easier by not having to redefine a new variable with a leo dark or light equivalent. It takes advantage of the fact that all Leo colors already have light and dark equivalents. UI that wishes to have different Leo colors for light and dark can and will still need to specify that explicitly.
Requires brave/leo#343
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: