Conversation
Brave syncer
Update sync nodes index only when we are about to moving the nodes from end to proper position
darkdh
force-pushed
the
brave-syncer-0.70.x
branch
from
9209cc0 to
d24ee89
Compare
kjozwiak
approved these changes
Aug 28, 2019
Member
kjozwiak
left a comment
kjozwiak
left a comment
There was a problem hiding this comment.
Uplift into 0.70.x approved after deliberating with @brave/uplift-approvers. Looks like CI/Travis passed and the only failure under CI/Jenkins was copying the files into S3. @btlechowski has also gone through brave/brave-browser#2754 (comment).
Please make sure that all the correct labels are added and the appropriate issue is moved into the correct milestone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplift of #2010 which is required by upcoming C77 bump
#3241 is the bookmark out of order fix