Repository navigation
bravebot reviews approve pull requests that put another repository's work in bravebot #3464
Description
bravebot pull requests put work that belongs to another repository into bravebot, and the bravebot review approves them. #4129 wrote what brave-experiments/brave-dev-loop should run into bravebot's security-audit skill, its selftest and docs/development/maintainer-jobs.md, and listed the brave-dev-loop rows as blocked in the body. That work belongs in the other repository.
Expected
- netzenbot-reviewer's bravebot profile, in brave-experiments/reviewer, reports added lines in a bravebot skill, script, doc, spec, comment or test that say what another repository should run, check or do, and a pull request description that lists such work as left or blocked in bravebot.
- A link to the other repository's pull request or issue is not a finding.
- bravebot's own skills and docs carry no rule about this. That was proposed in Do the other repository's part of an issue in that repository when implementing issues #4136 and closed: the check belongs in the reviewer's project config for bravebot.
Done already
- The brave-dev-loop side: Run security-audit.py --before-pr before opening a pull request on brave/bravebot brave-experiments/brave-dev-loop#219 and its pull request Run bravebot's security audit before the loop opens a bravebot pull request brave-experiments/brave-dev-loop#221 add
security-audit.py --before-pr upstream/mainto the bravebot profile's validations. - bravebot's
security-audit.py --before-pr BASElanded in Fail the layering test on unused workspace dependencies, and add a security-audit check for before a pull request #4129.
Activity
Pin the trust map and vouched programs in the changing-the-world table
Answer /btw beside a running turn, and pin the trust map and vouched …
netzenbot commentedon Oct 29, 2026
#958 asked that the lane check also runs before brave-dev-loop opens a pull request (the loop's W-11). That belongs to this issue, and it adds a condition to what the loop runs.
Before opening a pull request, the loop runs
/security-audit changed(orpython3 agents/skills/security-audit/security-audit.py --mechanical-only) when the diff touches the pathschanged_lanesselects for theapproval-bindinglane (agents/skills/security-audit/security-audit.py, functionchanged_lanes), and stops on a finding.The change is in
brave-experiments/brave-dev-loop, which this repository cannot change. The owner of that repository unblocks it.Describe security-audit.py --before-pr without naming another repository
Fail the layering test on unused workspace dependencies, and add a se…
[-]Run /security-audit changed in brave-experiments/brave-dev-loop before it opens a pull request, since nothing runs the audit on a branch before review[/-][+]implement-issues puts another repository's work in bravebot instead of opening a pull request in that repository[/+]netzenbot commentedon Nov 13, 2026
This issue now asks for the implement-issues change. The original request, running the audit in brave-dev-loop, is brave-experiments/brave-dev-loop#219, with its pull request brave-experiments/brave-dev-loop#221. The skill change is #4136.
[-]implement-issues puts another repository's work in bravebot instead of opening a pull request in that repository[/-][+]bravebot reviews approve pull requests that put another repository's work in bravebot[/+]netzenbot commentedon Nov 13, 2026
Moved to brave-experiments/reviewer#7, which adds the check to netzenbot-reviewer's bravebot profile, as the review comment on #4136 asked. That pull request closes this issue when it merges.
netzenbot commentedon Nov 13, 2026
Correction to the comment above: brave-experiments/reviewer#7 is now a security pass for bravebot reviews and no longer touches this issue or closes it.