Skip to content

Label the issues the flaky test workflow files with flaky-test - #3205

Merged
bbondy merged 1 commit into
brave:mainfrom
netzenbot:label-flaky-test-issues
Oct 25, 2026
Merged

bbondy merged 1 commit into
brave:mainfrom
netzenbot:label-flaky-test-issues

Conversation

@netzenbot

Copy link
Copy Markdown
Collaborator

The issues the Test determinism workflow files for a flaky test carry no label, so nothing lists
them together. contrib/measure-flakes.py now passes --label flaky-test for every issue it opens,
and no other label, since nobody has read what it files.

The issue-poster definition applies flaky-test to an issue about a flaky test filed from a
session. labelling-issues.md describes the label
and holds its creation command, which check-issue-posters requires for every label the definition
writes. checks.md and contrib/README.md say the workflow's issues carry it.

The label exists on the repository. Issues already filed are closed and stay unlabelled, and no
issue is open about a flaky test.

Not covered:

Testing

Plausible regression Test Evidence
The create call stops passing the label, or passes a second one every issue carries the flaky-test label and no other in the measure-flakes.py self-test Demonstrated: removing "--label", LABEL from the create arguments fails that check (1 of 28 failed); restored, 28 passed
The definition writes flaky-test and the labelling page does not describe it contrib/check-issue-posters.py Demonstrated: run against a copy of the page with the label renamed, it fails with "writes the label flaky-test, which docs/development/labelling-issues.md does not"

The self-test records the arguments a stand-in for gh receives. The workflow itself was not run,
so a real filing with the label is first exercised by the next Test determinism run.

Checks run on the final commit: make check-spec, contrib/measure-flakes.py --selftest, and the
formatter on contrib/measure-flakes.py.

contrib/measure-flakes.py passes --label flaky-test for every issue it opens, so
label:flaky-test lists the flakes the Test determinism workflow files. It applies no other label,
since nobody has read what it files.

The issue-poster definition applies flaky-test to an issue about a flaky test filed from a session.
labelling-issues.md describes the label and holds its creation command, which check-issue-posters
requires of every label the definition writes. checks.md and contrib/README.md say the workflow's
issues carry it.
@bbondy
bbondy merged commit 8e18f7b into brave:main Oct 25, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants