Repository navigation
Label the issues the flaky test workflow files with flaky-test - #3205
Merged
Merged
Conversation
contrib/measure-flakes.py passes --label flaky-test for every issue it opens, so label:flaky-test lists the flakes the Test determinism workflow files. It applies no other label, since nobody has read what it files. The issue-poster definition applies flaky-test to an issue about a flaky test filed from a session. labelling-issues.md describes the label and holds its creation command, which check-issue-posters requires of every label the definition writes. checks.md and contrib/README.md say the workflow's issues carry it.
bbondy
approved these changes
Oct 24, 2026
netzenbot-reviewer
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues the Test determinism workflow files for a flaky test carry no label, so nothing lists
them together.
contrib/measure-flakes.pynow passes--label flaky-testfor every issue it opens,and no other label, since nobody has read what it files.
The issue-poster definition applies
flaky-testto an issue about a flaky test filed from asession. labelling-issues.md describes the label
and holds its creation command, which
check-issue-postersrequires for every label the definitionwrites.
checks.mdandcontrib/README.mdsay the workflow's issues carry it.The label exists on the repository. Issues already filed are closed and stay unlabelled, and no
issue is open about a flaky test.
Not covered:
triage-issuesskill skips the issues the workflow files, because their author is a bot (The triage-issues skill skips bot-authored issues, so the flaky-test issues the Test determinism workflow files are never triaged #3204)Testing
every issue carries the flaky-test label and no otherin themeasure-flakes.pyself-test"--label", LABELfrom the create arguments fails that check (1 of 28 failed); restored, 28 passedflaky-testand the labelling page does not describe itcontrib/check-issue-posters.pyflaky-test, which docs/development/labelling-issues.md does not"The self-test records the arguments a stand-in for
ghreceives. The workflow itself was not run,so a real filing with the label is first exercised by the next Test determinism run.
Checks run on the final commit:
make check-spec,contrib/measure-flakes.py --selftest, and theformatter on
contrib/measure-flakes.py.