Return a range of elements rather than 1 single element #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cookie notices are structured like the following:
In this particular case:
The heuristics prior to this PR would identify element C as the cookie notice, when in reality, elements A and B could be hidden with equal success.
.modal:has-text(Your privacy choices)
could be a usable selector, but in this case#cookie_notice
would be an even better selector to choose since it's more precise (IDs are unique per-page), and procedural filters are more expensive in terms of runtime performance.In preparation for proposing filter rules, it will be important to calculate this kind of additional context. This PR introduces a "range" of elements that can be hidden. The innermost element must be hidden to remove the notice and any associated backdrop elements. Anything up to the outermost element can be considered for the purposes of hiding, in order to select the optimal rule.