Repository navigation
Conversation
DJAndries
force-pushed
the
encrypt-check
branch
from
November 10, 2026 01:37
7a021d0 to
9533351
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical encryption-check bypasses allow clients to persist plaintext credentials and browsing data, including through an unvalidated server-defined tag.
3 open issues
What changed in this PR
Adds server-side validation to help prevent clients from storing unencrypted sync specifics, addressing issue #375.
Changes:
- Checks entity specifics during conversion to datastore records, with exemptions for selected types.
- Reports rejected entities to Sentry.
- Adds validation and commit-response tests, and updates fixtures to include encrypted payloads.
| File | Description |
|---|---|
datastore/sync_entity.go |
Runs encryption validation before returning a datastore entity. |
datastore/encrypt_check.go |
Defines plaintext detection, exemptions, and Sentry reporting. |
datastore/encrypt_check_test.go |
Tests plaintext rejection, encrypted payloads, and exemptions. |
command/command_test.go |
Tests mixed-commit rejection responses and updates encrypted fixtures. |
Review effort: Balanced
mschfh
reviewed
Nov 10, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The password exemption accepts client_only_encrypted_data when unencrypted_metadata is absent, allowing plaintext usernames and passwords to be persisted even when an encrypted blob is present.
1 open issue
3 resolved since last review
Review effort: Balanced
mschfh
approved these changes
Nov 11, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #375