Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
d564bc8
chore(deps): update actions/checkout action to v7 (#433)
renovate[bot] Jul 13, 2026
768a936
chore(lint): fixes (#437)
mschfh Aug 28, 2026
5046a93
chore(lint): Fix dupl findings (#438)
mschfh Aug 28, 2026
8b6e12f
chore(lint): Fix govet shadowing findings (#440)
mschfh Aug 28, 2026
e51290d
chore(lint): fixes (#442)
mschfh Sep 10, 2026
71f27af
chore(lint): Fix nestif findings (#443)
mschfh Oct 16, 2026
ca8d4e1
chore(lint): Fix gocognit findings (#445)
mschfh Oct 20, 2026
4dbfd3d
chore(deps): update dependency go to 1.27 (#448)
renovate[bot] Oct 27, 2026
8fc4689
fix(deps): update module github.com/stretchr/testify to v1.12.1 (#452)
renovate[bot] Oct 27, 2026
c63464a
chore(deps): update actions/checkout action to v7.0.1 (#446)
renovate[bot] Oct 27, 2026
7fd177a
chore(deps): update public.ecr.aws/docker/library/golang docker tag t…
renovate[bot] Oct 27, 2026
92bcacf
chore(deps): update actions/setup-go action to v7 (#453)
renovate[bot] Oct 27, 2026
2a1b383
chore(deps): update alpine docker tag to v3.24 (#447)
renovate[bot] Oct 27, 2026
4e44536
chore(deps): update golangci/golangci-lint-action action to v9.3.0 (#…
renovate[bot] Oct 28, 2026
3aeee94
fix(deps): update module github.com/go-chi/chi/v5 to v5.5.0 (#451)
renovate[bot] Oct 28, 2026
31ad41a
fix(server): remove spoofable chiware.RealIP middleware (#454)
mschfh Oct 29, 2026
4033575
chore(lint): update golangci-lint config
mschfh Oct 29, 2025
8b2fa80
chore(lint): add ARGS support to golangci-lint command in Makefile
mschfh Oct 29, 2025
e90b8b5
chore(lint): add caching for golangci-lint in Makefile
mschfh Oct 29, 2025
5bf9a6d
chore(lint): disable godot, gochecknoglobals
mschfh Oct 29, 2025
18601f1
chore(lint): disnable protogetter linter and configure usestdlibvars
mschfh Nov 5, 2025
50bbabd
chore(lint): enable gofmt and modernize linters, add errcheck args.Ge…
mschfh Nov 5, 2025
70ad6c2
chore(lint): allow redis.Nil check
mschfh Nov 5, 2025
ca2b84d
chore(lint): disable mnd linter
mschfh Dec 2, 2025
c4f9bb4
chore(lint): ignore deprecated sync.proto fields
mschfh Aug 29, 2026
25b70bd
chore(lint): replace deprecated exhaustive map check with mapliteral
mschfh Oct 29, 2026
6db618d
Merge pull request #377 from brave/mschfh-lint-conf
mschfh Nov 6, 2026
2cc6844
Merge pull request #412 from brave/renovate/amazon-dynamodb-local-3-x
renovate[bot] Nov 6, 2026
76745a6
fix(deps): update aws-sdk-go-v2 monorepo (#428)
renovate[bot] Nov 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ jobs:
name: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
- uses: actions/setup-go@b7ad1dad31e06c5925ef5d2fc7ad053ef454303e # v7.0.0
with:
go-version: 1.26
go-version: 1.27

- name: lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9.3.0

test:
name: test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: test
run: make docker && make docker-test
491 changes: 463 additions & 28 deletions .golangci.yaml

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM public.ecr.aws/docker/library/golang:1.26 as builder
FROM public.ecr.aws/docker/library/golang:1.27 as builder

ARG VERSION
ARG BUILD_TIME
Expand All @@ -13,7 +13,7 @@ RUN CGO_ENABLED=0 GOOS=linux go build \
-ldflags "-X github.com/brave/go-sync/server.version=${VERSION} -X github.com/brave/go-sync/server.buildTime=${BUILD_TIME} -X github.com/brave/go-sync/server.commit=${COMMIT}" \
-o main .

FROM alpine:3.23 as artifact
FROM alpine:3.24 as artifact
RUN apk add --update ca-certificates # Certificates for SSL
COPY --from=builder /src/main main

Expand Down
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@ test:
go test -v ./...

lint:
docker run -t --rm -v "$$(pwd):/app" -w /app golangci/golangci-lint golangci-lint run -v
docker run -t --rm \
-v "$$(pwd):/app" \
-v go-sync-golangci-cache:/root/.cache/golangci-lint \
-w /app \
golangci/golangci-lint golangci-lint run -v $(ARGS)

clean:
rm -f sync-server
Expand Down
4 changes: 2 additions & 2 deletions auth/auth_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ func (suite *AuthTestSuite) TestAuthorize() {
}
for testName, test := range tests {
req.Header.Set("Authorization", test.token)
clientID, err := auth.Authorize(req)
suite.Require().Equal(test.err, err,
clientID, authErr := auth.Authorize(req)
suite.Require().Equal(test.err, authErr,
"error mismatched for %s test case", testName)
suite.Require().Equal(test.clientID, clientID,
"clientID mismatched for %s test case", testName)
Expand Down
4 changes: 2 additions & 2 deletions cache/cache.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ func (c *Cache) GetInterimCount(ctx context.Context, clientID string, countType
return count, nil
}

// IncrementInterimCount increments or decrements the amount of entities inserted in
// AdjustInterimCount increments or decrements the amount of entities inserted in
// the DB that were not yet added to the item count
func (c *Cache) IncrementInterimCount(
func (c *Cache) AdjustInterimCount(
ctx context.Context,
clientID string,
countType string,
Expand Down
Loading
Loading