This repository was archived by the owner on Jul 31, 2020. It is now read-only.
Conversation
darkdh
requested review from
AlexeyBarabash,
SergeyZhukovsky,
diracdeltas and
jhreis
Member
Author
|
|
AlexeyBarabash
previously approved these changes
Apr 18, 2019
Contributor
AlexeyBarabash
left a comment
AlexeyBarabash
left a comment
There was a problem hiding this comment.
Looks good @darkdh
AlexeyBarabash
dismissed stale reviews from SergeyZhukovsky and themself
via
3c72f2b
AlexeyBarabash
force-pushed
the
brave-syncer-staging
branch
from
a72d29c to
3c72f2b
Compare
…d missing 'parentFolderObjectId':[]
Create + Update + Update of an existing object should resolve to a separate Update
…ull. Can be squashed
…st to 'sequential Updates should become no op if the merged result equals to existingObject'
Merge by id action (staging)
Member
Author
|
can I get a re-review of this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for brave/brave-core#2010
Old code must deploy this new deps before above PR landed or it will get exception when. This change extends the protobuf definition but it won't affect the old code functionalityget-existing-objectson old code devices