Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PQ-7055] Clarify Unique Recipients #8675

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

diana-smirnova
Copy link
Contributor

@diana-smirnova diana-smirnova commented Dec 30, 2024

Why are you making this change? (required)

Several customers were confused by /sends/data_series stats because we include a unique_recipients stat for each send identifier, but unique recipients are counted at the campaign level, not the send ID level. This behavior is noted in the /sends/data_series response, but it can also be helpful to document it here.

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Dec 30, 2024
@internetisaiah internetisaiah self-requested a review December 31, 2024 01:24
@internetisaiah
Copy link
Contributor

hi @diana-smirnova , i'm on the docs team here at braze 👋🏽 is this one ready for review?

@diana-smirnova
Copy link
Contributor Author

diana-smirnova commented Jan 3, 2025

hi @diana-smirnova , i'm on the docs team here at braze 👋🏽 is this one ready for review?

Just need to double-check with the CSM that this docs update is necessary - I'll mark it as a draft for now

@diana-smirnova diana-smirnova marked this pull request as draft January 3, 2025 16:13
@internetisaiah internetisaiah removed their request for review January 6, 2025 23:12
@josh-mccrowell-braze
Copy link
Collaborator

Hi @diana-smirnova : Just following up about your progress checking in with the CSM about this PR! Thanks!

@diana-smirnova diana-smirnova force-pushed the pq-7055-unique-recipients branch from b12b07f to 04d7294 Compare January 15, 2025 14:16
@diana-smirnova
Copy link
Contributor Author

Hi @diana-smirnova : Just following up about your progress checking in with the CSM about this PR! Thanks!

Confirmed with the CSM that this update is necessary, the PR is now ready for review!

@josh-mccrowell-braze josh-mccrowell-braze merged commit cfadb56 into develop Jan 15, 2025
6 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the pq-7055-unique-recipients branch January 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants