Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melhorando os testes do método is_valid para o CNPJ #114

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Melhorando os testes do método is_valid para o CNPJ #114

merged 2 commits into from
Jul 1, 2023

Conversation

antoniamaia
Copy link
Contributor

@antoniamaia antoniamaia commented Jun 29, 2023

Melhorando os testes do método is_valid.cnpj:

closes #113

@antoniamaia
Copy link
Contributor Author

@camilamaia ainda não passei nos testes, mas acredito que tenha seguido a lógica do algoritmo cnpj.. só não mexi no código original, mas gostaria de te explicar como fiz em nosso próximo encontro! #113 in progress 💪🏼

@camilamaia
Copy link
Member

Opaaaa, parece que os testes tão no caminho certo! Eu não conferi a lógica do algoritmo ainda porque teria que parar com calma, mas os testes já vão nos ajudar a ver se está tudo implementado como esperado.

Arrasou! E a descrição e o título do PR tão mara ⭐

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #114 (114019c) into main (1b12ebf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #114   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files           3        3           
  Lines          65       65           
=======================================
  Hits           64       64           
  Misses          1        1           
Impacted Files Coverage Δ
brutils/cnpj.py 97.05% <100.00%> (ø)

@antoniamaia antoniamaia marked this pull request as ready for review July 1, 2023 09:36
@camilamaia camilamaia self-requested a review July 1, 2023 09:36
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somente perfeito 🌟

@camilamaia camilamaia merged commit 756f126 into brazilian-utils:main Jul 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criar mais testes para o utilitário is_valid_cnpj
2 participants