Cria função ibge.convert_text_to_uf que recebe um nome de estado e retorna sua UF. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphabraga
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 18 18
Lines 472 476 +4
=======================================
+ Hits 471 475 +4
Misses 1 1 ☔ View full report in Codecov by Sentry. |
BeneBr
reviewed
Jan 8, 2025
| from brutils.data.enums.uf import CODE_TO_UF | ||
| from unidecode import unidecode | ||
|
|
||
| from brutils.data.enums.uf import CODE_TO_UF, UF | ||
|
|
||
|
|
||
| def convert_code_to_uf(code): # type: (str) -> str | None |
There was a problem hiding this comment.
Apesar do brutils não utilizar algo como o mypy para verificação de tipos de maneira estática, recomendo fortemente utilizar tipagem no código mesmo ao invés de docstrings.
Suggested change
| def convert_code_to_uf(code): # type: (str) -> str | None | |
| def convert_code_to_uf(code: str) -> str | None: |
| @@ -30,3 +32,35 @@ def convert_code_to_uf(code): # type: (str) -> str | None | |||
| result = CODE_TO_UF(code).name | |||
|
|
|||
| return result | |||
|
|
|||
|
|
|||
| def convert_text_to_uf(state_name): # type: (str) -> str | None | |||
There was a problem hiding this comment.
Suggested change
| def convert_text_to_uf(state_name): # type: (str) -> str | None | |
| def convert_text_to_uf(state_name: str) -> str | None: |
| None | ||
| """ | ||
|
|
||
| federal_units = {unidecode(i.value.upper()): i.name for i in UF} |
There was a problem hiding this comment.
É realmente necessário utilizar essa nova dependência para tratar acentos? Ou tem alguma outra coisa que está dando errado e eu não estou percebendo?
Acredito que esse trecho possa ser definido assim:
federal_units= { uf.value.casefold(): uf for uf in UF}
return federal_units.get(state_name.casefold()), None)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Esse pull request tem a soluçao para issue #396 que define a criação de uma função ibge.convert_text_to_uf que recebe um nome de estado e retorna sua UF.
Mudanças Propostas
Checklist de Revisão
Comentários Adicionais (opcional)
Issue Relacionada
Closes #396