feat: phase-based passkey wizard with inline stepper#125
Open
erdemyerebasmaz wants to merge 2 commits intomainfrom
Open
feat: phase-based passkey wizard with inline stepper#125erdemyerebasmaz wants to merge 2 commits intomainfrom
erdemyerebasmaz wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Each WebAuthn operation (listLabels, getWallet, storeLabel, createPasskey) now creates a fresh Passkey instance internally, ensuring every prompt is preceded by a user interaction. Adds createPasskey and setPasskeyMode exports. Removes singleton caching from passkeyPrfProvider.
Replace overlay stepper with a horizontal top-bar StepperBar that renders inline in PasskeyPage. The page manages a phase state machine covering both new-user (Create Passkey → Connect to Nostr → Initialize) and returning-user (Your Label → Initialize) flows. - Add StepperBar component with numbered circles and connector lines - Add PasskeyIcon (FIDO Alliance standard, three-tone depth) and NostrKeyIcon for the label picker - Label input: 24-char alphanumeric limit, duplicate detection, sticky manual-input mode - Explicit new-storing phase for reliable relay label storage - Simplify App.tsx: remove overlay stepper state, signal SDK connection via sdkConnected prop
3028c74 to
d3a9556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guided passkey onboarding wizard that adapts to new and returning users, with reliable label storage and FIDO-standard icons.
Summary
listLabels()WebAuthn callpasskeyPrfProviderwith pure WebAuthn functions, injectable config, and fresh Passkey instance per operation (removes singleton caching to prevent stale state)Label input improvements
new-storingphase (replaces fire-and-forgetstoreLabelwhich caused a surprise WebAuthn prompt and silently failed)Icon updates
FingerprintIconwith FIDO Alliance standardPasskeyIcon(platform-agnostic — passkeys don't always use biometrics)UploadIconwithNostrKeyIcon(key/plug from nwc.dev) for the label picker screenTest plan
npx tsc --noEmitpasses