Conversation
dangeross
force-pushed
the
savage-seedless-restore
branch
2 times, most recently
from
01f6c78 to
5b349bb
Compare
roeierez
pushed a commit
that referenced
this pull request
Jan 12, 2026
Review covers core implementation, CLI, WASM/Flutter bindings, and documentation with specific concerns and suggestions.
dangeross
force-pushed
the
savage-seedless-restore
branch
from
5b349bb to
02c109e
Compare
Collaborator
Author
|
@claude short PR review |
This comment was marked as outdated.
This comment was marked as outdated.
dangeross
force-pushed
the
savage-seedless-restore
branch
from
133157c to
b654930
Compare
1 task
dangeross
force-pushed
the
savage-seedless-restore
branch
2 times, most recently
from
31afe9e to
4770ffe
Compare
roeierez
reviewed
Feb 17, 2026
crates/breez-sdk/core/Cargo.toml
Outdated
| lnurl-models.workspace = true | ||
| macros.workspace = true | ||
| nostr.workspace = true | ||
| nostr-sdk.workspace = true |
Member
There was a problem hiding this comment.
Can we make the seedless restore optional along with this dependency? I think we should maintain our effort to minimize dependencies.
I wonder also if it is a good idea to take the seedless restore functionality to its own crate as it seems pretty independent.
dangeross
force-pushed
the
savage-seedless-restore
branch
from
9baa974 to
1640c8d
Compare
dangeross
force-pushed
the
savage-seedless-restore
branch
3 times, most recently
from
68c6190 to
2a65e51
Compare
dangeross
force-pushed
the
savage-seedless-restore
branch
from
2a65e51 to
725c210
Compare
dangeross
force-pushed
the
savage-seedless-restore
branch
from
bb51c93 to
6738e0d
Compare
dangeross
force-pushed
the
savage-seedless-restore
branch
2 times, most recently
from
c659bad to
608cdf6
Compare
dangeross
force-pushed
the
savage-seedless-restore
branch
from
608cdf6 to
0732b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a gated
Passkeyutility withPasskeyPrfProvidertrait interface to implement a platform interface with a WebAuthn passkey PRF extension.Seedless Restore Spec
Glow Web implementation
TODO:
I think if we are to provide prewritten native plugin for android/iOS we should do so in a follow up PR
Closes #471