Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: uncouple secrets loader #1652

Closed
wants to merge 1 commit into from
Closed

feat: uncouple secrets loader #1652

wants to merge 1 commit into from

Conversation

jaulz
Copy link

@jaulz jaulz commented Sep 25, 2023

Right now, the logic whether the secrets loader will be used or not is implemented here in the first place. However, I think it should only be used to output a warning. That makes it easier to patch the secrets loader and for example use this proposed change: brefphp/secrets-loader#4

@mnapoli
Copy link
Member

mnapoli commented Sep 29, 2023

I don't understand what this is about honestly.

However, I think it should only be used to output a warning

But the diff still throws an exception, so I'm not sure what you mean.

How are things different with that PR? What can you do that you couldn't do before?

@jaulz
Copy link
Author

jaulz commented Sep 29, 2023

Actually, this is something I stumbled across when implementing brefphp/secrets-loader#4. In my opinion Bref should only check (but not prevent) loading of secrets via secrets manager. Currently, this package needs to be kept in sync with secrets loader because areThereSecretsToLoad needs to know the syntax of the secrets. At the moment it's easy to keep it in sync but it prevents users from patching the secrets loader with custom logic.

I didn't want to remove the original check to keep the existing behaviour so I kept the exception.

@mnapoli
Copy link
Member

mnapoli commented Mar 19, 2024

Closing to clean up the issue tracker, that's not something I plan on merging right now. Let's reopen the discussion if needed.

@mnapoli mnapoli closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants