Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 918: Call screen always keep at 00:00 time (connecting) after manually allow Notification permissions #295

Merged
merged 3 commits into from
Oct 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fix ios it should keep the call when screen is off by proximity sensor for 90 seconds (issue 891)
- Fix it should be touchable to toggle buttons in video calls (issue 897)
- Fix android it should answer call immediately with x_autoanswer (issue 908)
- Fix it should display call duration correctly after manually allow Notification permissions (issue 918)
- Fix it should load video when turning it on from a voice call (issue 934)

#### 2.14.10
Expand Down
10 changes: 5 additions & 5 deletions src/utils/PushNotification.android.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,6 @@ export const PushNotification = {
onFcmToken(e.deviceToken)
})

// we should be able to get fcm token without permission request
if (!hasPermissions) {
throw new Error(intl`Don't have Permissions`)
}

events.registerRemoteNotificationsRegistrationFailed(
(e: RegistrationError) => {
console.error('Failed to register remote notification', e)
Expand Down Expand Up @@ -144,6 +139,11 @@ export const PushNotification = {
const payload = n?.payload?.payload || n?.payload
onNotification(payload, initApp, true)
})

// we should be able to get fcm token without permission request
if (!hasPermissions) {
throw new Error(intl`Don't have Permissions`)
}
} catch (err) {
console.error(
'PushNotification register error: Failed to initialize push notification',
Expand Down