Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 964: can't here RBT when make call without SDP #296

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Fix issue 964: can't here RBT when make call without SDP #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9e0708
Fix issue: can't here RBT when make call with out SDP
tatthangcntt Sep 11, 2024
548767c
update format code
tatthangcntt Sep 18, 2024
d213590
Merge branch 'master' into bug_964
namnm Oct 7, 2024
f2c5b0b
nam
namnm Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Fix android it should answer call immediately with x_autoanswer (issue 908)
- Fix it should display call duration correctly after manually allow Notification permissions (issue 918)
- Fix it should load video when turning it on from a voice call (issue 934)
- Fix it should play RBT when make call without SDP (issue 964)

#### 2.14.10

Expand Down
8 changes: 4 additions & 4 deletions src/components/CallVoices.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const CallVoices = observer(() => {
void cs.calls.map(_ => _.callkeepUuid)

const oc = cs.getOngoingCall()
const isOutgoingProgress =
oc && !oc.incoming && !oc.answered && oc.sessionStatus === 'progress'
const isOutgoing = oc && !oc.incoming && !oc.answered
const isOutgoingProgress = isOutgoing && oc.sessionStatus === 'progress'

// when receive a 18x response (usually 180 or 183) with SDP
// don't play the local RBT, but the audio data in the RTP packets
Expand All @@ -26,8 +26,8 @@ export const CallVoices = observer(() => {

return (
<>
{isOutgoingProgress &&
(playEarlyMedia ? (
{isOutgoing &&
(isOutgoingProgress && playEarlyMedia && oc.earlyMedia ? (
<OutgoingItemWithSDP earlyMedia={oc.earlyMedia} />
) : (
<>
Expand Down