Repository navigation
Conversation
nuriyoo
marked this pull request as ready for review
October 28, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md says where a new test case goes when an existing test already sends its request, and AGENTS.md has an agent look for that test before writing a new function.
What changed
CONTRIBUTING.md. Item 3 of Pull requests gains the rule: the case is a row of the existing test's table, a refusal and its successful counterpart on one URL are one table, and a new function is kept for a state or an assertion no test has yet.AGENTS.md. One bullet under Tests: the search to run before writing a new test function, then the rule in one clause with a pointer to item 3, as the bullet on titles and descriptions points to items 5 and 6..claude/agents/behaviour-reviewer.md(item 4, "Tests did not sprawl"), step 6 of.claude/skills/backlot-loop/SKILL.mdand item 7 of.claude/skills/backlot-debloat/SKILL.mdalready ask this of a pull request. This pull request leaves those three files as they are.Why this is what the real API does
No vendor behaviour changes. The rule was written in the reviewer agent's checklist and two skills, and not in CONTRIBUTING.md or AGENTS.md, where a contributor and their agent look before writing a test. Reviews here often ask a contributor to fold a test into an existing table after it was written as a new function. Stated in those two files, it can be followed the first time.
Verification
PYTHONWARNDEFAULTENCODING=1 pytest -rson auv sync --all-extras --lockedinstall, plusllama-index-readers-hubspot<0.6as CONTRIBUTING.md says: 8810 passed, 1 skipped.tests/test_mcp.py:102, mcp-atlassian, with no Docker daemon running.ruff check . && ruff format --check .: All checks passed, 193 files already formatted.At
831e94d9, onmainatf420eda2.tests/test_docs.pychecks their links and passes.