Removing unused variable and whitespace #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much, PR#4 and PR#5 is accepted. I will review PR#6 for more time. I am very glad that you contribute those useful code to the project, especially PR#4 (remove the unused variables, which means you reviewed very carefully). And, ..., I hope you can understand my pool English :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, @brg-liuwei. Thanks for this NGINX module code! I have been looking through it to understand it and made a few changes in the process. I'm opening a few pull requests in case you are interested in merging them back into your repository, but if you prefer not to do that, no worries!
This pull request removes the declaration of an unused variable and a couple instances of trailing whitespace.