LPD-68814 Lower log level #166813
Closed
LPD-68814 Lower log level #166813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ERROR level was breaking some CI tests because PortletRenderUtil is logging the message when it cannot find a CSS file. We used error because we assumed all CSS files requested by that class should exist, but in the case of tests, they don’t. Now we lower the log message to DEBUG because the tokenized feature is only used for legacy code and if a CSS file that has tokens cannot be found by PortletRenderUtil and it ends up causing a visible error, it should be a fairly straightforward process to diagnose it, activating the traces if necessary. (see https://liferay.atlassian.net/browse/LPD-68304?focusedCommentId=30544639)
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesRan com.liferay.source.formatter at released version 1.0.1545. Click here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-68814 1 Successful Jobs:For more details click here. |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#5137 (Took 4
ci:forwardattempts in 3 days 2 hours 15 minutes)Console
@izaera
@liferay-frontend
Original pull request comment:
The ERROR level was breaking some CI tests because PortletRenderUtil is logging the message when it cannot find a CSS file. We used error because we assumed all CSS files requested by that class should exist, but in the case of tests, they don’t.
Now we lower the log message to DEBUG because the tokenized feature is only used for legacy code and if a CSS file that has tokens cannot be found by PortletRenderUtil and it ends up causing a visible error, it should be a fairly straightforward process to diagnose it, activating the traces if necessary.
(see https://liferay.atlassian.net/browse/LPD-68304?focusedCommentId=30544639)