Skip to content

Conversation

debarshiray
Copy link
Contributor

The vendor directory was updated with go mod vendor.

Otherwise make test fails with:

  $ make test
  go test -v -cover ./...
  go: inconsistent vendoring in /path/to/briandowns/spinner:
	golang.org/x/[email protected]: is
	    explicitly required in go.mod, but not marked as explicit in
	    vendor/modules.txt
	golang.org/x/[email protected]: is marked
	    as explicit in vendor/modules.txt, but not explicitly
	    required in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
  make: *** [Makefile:12: test] Error 1

Fallout from 12e6c29

@briandowns
Copy link
Owner

Thank you for the contribution. I've been meaning to simply get rid of the vendor directory in this branch but haven't since I'm working on the v2 replacement. I'd rather we just remove the vendor directory entirely.

The 'vendor' directory was removed because it keeps getting outdated
compared to go.mod.

Otherwise 'make test' fails with:
  $ make test
  go test -v -cover ./...
  go: inconsistent vendoring in /path/to/briandowns/spinner:
	golang.org/x/[email protected]: is
	    explicitly required in go.mod, but not marked as explicit in
	    vendor/modules.txt
	golang.org/x/[email protected]: is marked
	    as explicit in vendor/modules.txt, but not explicitly
	    required in go.mod

	To ignore the vendor directory, use -mod=readonly or -mod=mod.
	To sync the vendor directory, run:
		go mod vendor
  make: *** [Makefile:12: test] Error 1

Fallout from 12e6c29
@debarshiray debarshiray force-pushed the wip/rishi/unbreak-make-test-go-mod-vendor branch from 6e9b126 to 508a84e Compare November 5, 2024 16:24
@debarshiray
Copy link
Contributor Author

Thanks for the review!

Thank you for the contribution. I've been meaning to simply get rid of the vendor directory in this branch but haven't since I'm working on the v2 replacement. I'd rather we just remove the vendor directory entirely.

I have now removed the vendor directory completely.

@QuLogic
Copy link

QuLogic commented Jan 21, 2025

Some of the vendor removal might have already occurred in #163, I think.

@debarshiray
Copy link
Contributor Author

Some of the vendor removal might have already occurred in #163, I think.

Indeed. It fixed make test in Git master.

@debarshiray
Copy link
Contributor Author

The original motivation for this pull request no longer applies. However, if you want to remove the rest of the vendor directory, then I will be happy to rebase this PR on top of Git master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants