Skip to content

Clear flatware-sink #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clear flatware-sink #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29674f
Clear flatware-sink on `clear` command
MatheusRich Sep 23, 2025
f51131d
Stop DRb service on exit
MatheusRich Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/flatware/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
require 'thor'
require 'flatware/pid'
require 'etc'
require 'fileutils'

module Flatware
# shared flatware cli
Expand Down Expand Up @@ -50,6 +51,8 @@ def clear
(Flatware.pids - [Process.pid]).each do |pid|
Process.kill 6, pid
end

FileUtils.rm_f('flatware-sink')
Copy link
Author

@MatheusRich MatheusRich Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like options['sink-endpoint'] isn't available here, so I went with the default name. LMK if there's a better way to handle this.

end

private
Expand Down
2 changes: 2 additions & 0 deletions lib/flatware/sink.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ module Flatware
module Sink
module_function

at_exit { DRb.stop_service }
Copy link
Author

@MatheusRich MatheusRich Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just copied @briandunn's suggestion. LMK If this shouldn't be here.


def start_server(**args)
Server.new(**args).start
end
Expand Down
Loading