mssql multi driver dsn #7
Conversation
drmuey
commented
Feb 4, 2016
drmuey
commented
- Added dbd_driver()
- Fixed up POD
- moved some mssql specific attributes to mssql.pm
- updated https://github.com/brianmckeen/sqitch/wiki/MSSQL-TODO to reflect things we know still needs done.
…vers (noop until URI::db is updated), fix POD, add POD for changing the driver
|
Its safe to review, I won't push any more to this pull request. I'll start the tests in another branch. thanks! |
|
unless the change needs adjusted of course based on your feedback ;) |
…since its the onlt funciton used fromt hat module
|
ok, I lied sorry; that was the finally one, switching gears now to unit tests in another branch |
|
While testing I found 2 problems that needed fixed. Since this has not merged yet I went ahead and added them to this pull request. Thanks! |
drmuey
force-pushed
the
mssql_multi_driver_dsn
branch
from
7ff4974 to
a3badb5
Compare
|
I found another problem during testing that needs fixed. Since this has not merged yet I went ahead and added them to this pull request. Thanks! |
drmuey
force-pushed
the
mssql_multi_driver_dsn
branch
from
fd6e5e4 to
2ceb1eb
Compare
|
Good morning Brian! I really hate to expand this pull request any more, would you be in a position to review and merge it so I can do specific branches for the remaining specific tasks? Thanks! |
drmuey
force-pushed
the
mssql_multi_driver_dsn
branch
from
ed29c0b to
7dd7456
Compare
|
Good afternoon Brian, I have everything at https://github.com/brianmckeen/sqitch/wiki/MSSQL-TODO done except writing unit tests and then adding any new prereqs for the dist. Would you be in a position to review this pull request in the next few days? After its merged I can do the unit tests and prereq changes in a separate branch. Thanks! |
|
Good morning Brian, Would you be in a position to review this pull request in the next few days? Details are in the previous post. Thanks! |
