Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: address shellcheck warnings #1993

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

style: address shellcheck warnings #1993

wants to merge 8 commits into from

Commits on Mar 13, 2024

  1. use $@ over $*. SC2048 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    fd5ca3f View commit details
    Browse the repository at this point in the history

  2. prevent globbing and word splitting. SC2086 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a1e7a30 View commit details
    Browse the repository at this point in the history

  3. read without -r will mangle backslashes. SC2162 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    99d56aa View commit details
    Browse the repository at this point in the history

  4. simplify by using -n. SC2236 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    bd01342 View commit details
    Browse the repository at this point in the history

  5. prevent shell from interpreting the -name value. SC2061 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    739aa48 View commit details
    Browse the repository at this point in the history

  6. prevent globbing and word splitting. SC2086 

    I agree to license my contributions to each file under the terms given
at the top of each file I changed.
    @reubenmiller
    reubenmiller committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    896ea2f View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. fixup! prevent globbing and word splitting. SC2086

    @reubenmiller
    reubenmiller committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9a18e6f View commit details
    Browse the repository at this point in the history

  2. fixup! prevent globbing and word splitting. SC2086

    @reubenmiller
    reubenmiller committed May 14, 2024
    Configuration menu
    Copy the full SHA
    31dc1e6 View commit details
    Browse the repository at this point in the history