Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes: Clarify counter overflow checking. #2120

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Commits on Jun 24, 2024

  1. aes: Move Counter & Iv to their own submodule.

    Move all the counter management to a submodule that can, in the future,
    be encapsulated from the rest of the AES and AES-GCM logic.
    
    `git difftool HEAD^1:src/aead/aes.rs src/aead/aes/counter.rs`
    briansmith committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    926c6d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d214d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. aes: Clarify counter overflow checking.

    Move `Conuter` and `Iv` to aes/counter.rs.
    
    Create a more robust internal API for counter/nonce/IV management that
    makes the usage within AES-GCM more clearly correct. The new design is
    easier to test.
    
    `git difftool HEAD^1:src/aead/aes.rs src/aead/aes/counter.rs`
    briansmith committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0a0d1a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    812ebfc View commit details
    Browse the repository at this point in the history