Remove #[inline] attributes on function prototypes#914
Merged
briansmith merged 1 commit intobriansmith:masterfrom Dec 23, 2019
LukasKalbertodt:master
Merged
Remove #[inline] attributes on function prototypes#914briansmith merged 1 commit intobriansmith:masterfrom LukasKalbertodt:master
#[inline] attributes on function prototypes#914briansmith merged 1 commit intobriansmith:masterfrom
LukasKalbertodt:master
Conversation
These attributes now lead to a compile error on nightly.
Merged
Contributor
Author
|
Could this and #913 be merged soon? Both are just tiny fixes. Though I saw that this crate seems to be unmaintained in the recent months? Is @briansmith the only one who can merge? If you read that, @briansmith, could you consider getting the Rust Bus on board? I understand very well if you can't maintain this crate at the moment; life can always get in the way. But since (The CI failure in this case is just from coveralls. But obviously, this change did not actually decrease or increase coverage.) |
briansmith
approved these changes
Dec 23, 2019
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes now lead to a compile error on nightly. See this Rust PR for more information.