Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64-pc-windows-msvc to CI (build only). #287

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

briansmith
Copy link
Owner

Build webpki on aarch64-pc-windows-msvc. Don't run it since there are no aarch64-pc-windows-msvc runners available.

@briansmith briansmith self-assigned this Oct 2, 2023
@briansmith
Copy link
Owner Author

This is blocked on #286 (upgrade to ring 0.17.0) and on upgrading to a rcgen that uses 0.17.0

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #287 (c89bde8) into main (e7873ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   57.43%   57.43%           
=======================================
  Files          21       21           
  Lines        3597     3597           
=======================================
  Hits         2066     2066           
  Misses       1531     1531           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briansmith briansmith force-pushed the b/aarch64-pc-windows-msvc branch 2 times, most recently from 8c3453d to 66a4287 Compare October 7, 2023 06:57
@briansmith
Copy link
Owner Author

This is blocked on [...] upgrading to a rcgen that uses 0.17.0

I used an allowlist of target architectures to decide whether to make rcgen a dev-dependency and whether to enable the rcgen-based tests. Will undo this when rcgen uses ring 0.17.

@briansmith briansmith force-pushed the b/aarch64-pc-windows-msvc branch 2 times, most recently from 992fd88 to b612118 Compare October 8, 2023 17:33
There are no runners in GitHub Actions so we can't run the tests, but at least
we can build them.
@briansmith briansmith merged commit b16d543 into main Oct 8, 2023
260 checks passed
@briansmith briansmith deleted the b/aarch64-pc-windows-msvc branch October 8, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant