Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Faker for Music #370

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

barkhayot
Copy link

@barkhayot barkhayot commented Dec 8, 2024

  • Introduced new functions to generate random music-related data
  • MusicName, MusicArtist, and MusicGenre for generating random music names, artists, and genres.
  • MusicInfo struct for encapsulating music-related details (Name, Artist, Genre).
Music() *MusicInfo
MusicName() string
MusicArtist() string
MusicGenre() string

@barkhayot barkhayot marked this pull request as ready for review December 8, 2024 05:24
@brianvoe
Copy link
Owner

brianvoe commented Dec 9, 2024

First of all nice job on the initial pr!

Couple of things to finish this and ill get it merged

  1. Make sure the examples output the value. The seed(11) should keep your output consistent, tests are failing
  2. For the data lets try to get a top list for each, or let me know where you got this list from
  3. Artists have featuring at the end of there name lets remove those
  4. For name lets change it to song
  5. Lets also alphabetize the list too please

Other than that it should be good to go. Great job!

@barkhayot
Copy link
Author

First of all nice job on the initial pr!

Couple of things to finish this and ill get it merged

  1. Make sure the examples output the value. The seed(11) should keep your output consistent, tests are failing
  2. For the data lets try to get a top list for each, or let me know where you got this list from
  3. Artists have featuring at the end of there name lets remove those
  4. For name lets change it to song
  5. Lets also alphabetize the list too please

Other than that it should be good to go. Great job!

Thank you for the feedback! I'll push updates soon

@barkhayot
Copy link
Author

barkhayot commented Dec 15, 2024

Updates

  • Converted from Music to Song
  • Dataset is updated based on feedbacks. Added top list for each column
  • Added sources for dataset
  • Dataset is sorted alphabetically
  • Fixed tests based on needed output

Example

Song() *SongInfo
SongName() string
SongArtist() string
SongGenre() string

Tests

home/bash$ go test .
ok  	github.com/brianvoe/gofakeit/v7	2.210s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants