Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 Import #1

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Use ES6 Import #1

merged 3 commits into from
Jan 18, 2021

Conversation

rubas
Copy link
Contributor

@rubas rubas commented Jan 12, 2021

As mentioned in brianzinn/react-babylonjs#110 .

@brianzinn brianzinn merged commit a4f6c20 into brianzinn:master Jan 18, 2021
@brianzinn
Copy link
Owner

thanks rubas really appreciate you making this PR - Will put out an NPM after updating rollup.

@brianzinn
Copy link
Owner

hi @rubas I have made some additional changes for rollup - the imports changed to ie: @babylonjs/core/scene and were not being resolved as external, so the package was 1.5 MB (instead of 47kB!) and I was seeing duplicates in the treemap as well. You can try with yarn add [email protected]. In a CRA project what I noticed was no difference on the build size - are you able to verify against the beta version that I published? I see the client.html treemap is 7.94MB (stat) --> 3.44MB (parsed) --> 803kB (gzip) according to the analyzer, but I'm getting that with new and original versions (I didn't read up on next-transpile-modules). I'm hoping to get everything sorted out here before trying to fix react-babylonjs. I'm trying to find the 2MB difference that you reported on the react-babylonis issue, so hoping you can show me where that is. Thanks for your help 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants