add alt prop to the image #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding `alt` attribute to the `img` element to enhance the accessibility and the Semantic UI
|
@coder-abdo thanks for the contribution! Sorry to nitpick, but I'm reluctant to go with "company logo" just because we're not really a company. Let's go with "Brigade Logo". Sound ok? |
|
that is great and it is fit to the project nicely |
|
@coder-abdo it looks like you amended the commit after our previous conversation, but I still don't see the change we discussed. Did something go wrong? |
|
I changed here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
adding
altattribute to theimgelement to enhance the accessibility and the Semantic UI