This repository has been archived by the owner on Aug 14, 2018. It is now read-only.
🐛 fixing save brigade info (patch) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in reference to brigadehub/brigadehub#465 and #4 - changes the redirect URL to `/admin/brigade`, the real brigade manage page since the admin app mounting - changes the criteria for saving theme information from the form, `slug` has been deprecated in favor of `admin` and `public` (alpha release remnants)
|
Also related: brigadehub/core#15 - the brigade model is in dire need of refactoring. |
|
Review of the code seems good, merging in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to brigadehub/brigadehub#465 and #4
/admin/brigade, the real brigade manage page since the admin app mountingslughas been deprecated in favor ofadminandpublic(alpha release remnants)