Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Try to build the assets
run: |
npm ci
npm run production
npm run build
rm -rf node_modules

- uses: shivammathur/setup-php@v2
Expand Down
21 changes: 5 additions & 16 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,13 @@ jobs:
- name: Try to build the assets
run: |
npm ci
npm run production
npm run build

- name: Upload built assets
uses: actions/upload-artifact@v7
with:
name: assets
path: public/assets/dist

- name: Upload mix manifest
uses: actions/upload-artifact@v7
with:
name: mix-manifest
path: public/mix-manifest.json
name: vite-build
path: public/build

test-php:
name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
Expand All @@ -52,13 +46,8 @@ jobs:

- uses: actions/download-artifact@v8
with:
name: assets
path: public/assets/dist

- uses: actions/download-artifact@v8
with:
name: mix-manifest
path: public
name: vite-build
path: public/build

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/node_modules
/logs
/public/hot
/public/build
/public/storage
/public/mix-manifest.json
/storage/*.key
/tests/Controller/logs
/vendor
Expand Down
18 changes: 16 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,18 @@ docker compose exec -it php composer install
docker compose exec -it php php artisan key:generate
```

Last step: compile all assets. Node 20 LTS is the minimum version required and recommended to use. You may use either
NPM or Yarn for installing the asset dependencies.
Last step: install and build the frontend assets. Node 22 LTS is the minimum version required and recommended to use.
Use NPM to install dependencies. During active frontend work, keep the Vite dev server running in a separate shell.

```bash
npm install

npm run build
```

For active frontend development with live reload:

```bash
npm run dev
```

Expand Down Expand Up @@ -100,3 +106,11 @@ maintainers.
```bash
docker buildx build --push --platform "linux/amd64,linux/arm64,linux/arm/v7" -t linkace/base-image:2.x-php-8.5 -f resources/docker/dockerfiles/release-base.Dockerfile .
```

## Testing the Docker release build

Run the following command locally to test if the release Docker image can successfully be built.

```bash
docker buildx build --platform "linux/amd64,linux/arm64,linux/arm/v7" -t linkace/release-test -f resources/docker/dockerfiles/release-multiplatform.Dockerfile .
```
Loading
Loading