ignore generated assets folder #751

ugifractal · 2025-09-20T02:20:31Z

this PR add ignore for generated assets folder from vite build

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

* Refactor tailwind.css: Change import statement to use URL and reorganize hover effect styles * Refactor role styles in tailwind.css: Consolidate border and color properties for roles * Fix import statement and clean up whitespace in tailwind.css

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

* Natural language fixes in Markdown files * Update DEVELOPER_HELP.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

…ess#590)

) * Format base.njk with Prettier and run pre-commit hooks * Optimize PNGs via pre-commit (oxipng) * Unchanged package-lock.json and package.json * Removed Cdn * Apply pre-commit autofixes (EOF newline, oxipng) * Update frontend/_includes/layouts/base.njk --------- Co-authored-by: John Bampton <[email protected]>

* Create .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update .deepsource.toml

* Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Validate codecov.yml file with curl * Fix up

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

…cialchess#712)

)

gemini-code-assist · 2025-09-20T02:20:40Z

Summary of Changes

Hello @ugifractal, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving repository cleanliness by updating the .gitignore file. The change ensures that the assets/ directory, which typically contains generated build output from tools like Vite, is excluded from version control. This prevents unnecessary files from being committed and keeps the repository focused on source code.

Highlights

Git Ignore Update: Added assets/ to the .gitignore file to prevent generated build assets from being tracked by Git.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

deepsource-io · 2025-09-20T02:20:48Z

Here's the code health analysis summary for commits 4edd459..ee7f268. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Python	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
Shell	✅ Success		View Check ↗
Docker	✅ Success	🎯 1 occurence resolved	View Check ↗
JavaScript	✅ Success		View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

gemini-code-assist

Code Review

This pull request aims to ignore generated assets from the Vite build process by adding assets/ to the .gitignore file. My review of the project's configuration files (vite.config.js and package.json) suggests that the build artifacts are actually generated in the _site/ and _deploy/ directories. Therefore, adding assets/ to .gitignore might not achieve the desired outcome. I've provided a suggestion to ignore the correct build output directories to ensure generated files are not tracked by version control.

gemini-code-assist · 2025-09-20T02:21:39Z

.gitignore


 # Build output
 dist/
+assets/


While the intention to ignore generated assets is correct, the build configuration (vite.config.js) indicates that Vite's build output is placed in the _deploy/ directory. The generated assets will be inside _deploy/assets/.

Therefore, adding assets/ here will not have the intended effect for Vite's output. To ignore all build artifacts correctly, you should consider ignoring the main build output directories:

Eleventy's output directory: _site/

Vite's output directory: _deploy/

I'd suggest ignoring these directories instead to ensure all generated files are correctly excluded from version control.

_site/ _deploy/

socket-security · 2025-09-22T12:43:46Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@cloudflare/vitest-pool-workers@0.8.69
	vitest@3.2.4
	wrangler@4.33.2

View full report

$ugifractal$

ugifractal and others added 30 commits September 4, 2025 21:17

$@ugifractal$

Use latest ubuntu

7824584

$@ugifractal$

Use target arch

e945335

$@ugifractal$

Increase nvm version

2f06760

Merge branch 'main' into improve-docker-pre-commit

3b5008f

$@ugifractal$

Fix run layers

805ab58

Merge branch 'main' into improve-docker-pre-commit

682dc26

$@ugifractal$

* Fix Dockerfile with separate user

abdd5a6

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

$@ugifractal$

Fix 404 not found page (brisbanesocialchess#578)

42858f4

$@ugifractal$

Remove duplicate npm-ci hook; refactor local hooks (brisbanesocialche…

fd7ef14

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

$@ugifractal$

Update prettierignore and run (brisbanesocialchess#582)

7cd1e44

$@ugifractal$

pre-commit prettier check JS files (brisbanesocialchess#587)

03574fb

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

$@ugifractal$

Add eslint ignore for the Sphinx doc folder (brisbanesocialchess#589)

7719163

$@ugifractal$

Update README.md add Cloudflare Pages status button (brisbanesocialch…

743e0c2

…ess#590)

$@ugifractal$

Update README.md fix read the docs button link (brisbanesocialchess#591)

a8a234b

$@ugifractal$

Update .deepsource.toml (brisbanesocialchess#600)

7cc995b

* Update .deepsource.toml

$@ugifractal$

Fix conflict

fe40d3e

$@ugifractal$

add pipefail

ea48ec0

$@ugifractal$

add version

7a41cc7

$@ugifractal$

add --no-cache

d9db89f

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

4c6ba1c

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

e177dbd

$@ugifractal$

Validate codecov.yml file with curl (brisbanesocialchess#710)

2b46e57

* Validate codecov.yml file with curl * Fix up

$@ugifractal$

Test Docker with GitHub Actions (brisbanesocialchess#711)

6b58c14

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

$@ugifractal$

Update dprint.yml add name key with emoji value and title (brisbaneso…

39080eb

…cialchess#712)

$@ugifractal$

Update codecov.yml set require_changes: false (brisbanesocialchess#714

81e2d86

)

ugifractal added 2 commits September 19, 2025 13:04

$@ugifractal$

add pinned version to coverage

280f42b

$@ugifractal$

ignore generated assets folder

04687b5

$@ugifractal$ ugifractal requested a review from jbampton as a code owner September 20, 2025 02:20

github-actions bot added chore root labels Sep 20, 2025

gemini-code-assist bot reviewed Sep 20, 2025

View reviewed changes

$@ugifractal$ ugifractal mentioned this pull request Sep 20, 2025

Bug: pre-commit run eleventy-build-check --all-files creates a wrong duplicate assets directory in the repo root #707

Open

ugifractal added 15 commits September 20, 2025 09:30

$@ugifractal$

pin coverage

2cdfa38

$@ugifractal$

pin version

fe04173

$@ugifractal$

run stylelint --fix

c8ff95e

$@ugifractal$

coverage to use sha

a78cb73

$@ugifractal$

use sha

6a189b4

$@ugifractal$

use sha

007062d

$@ugifractal$

use sha

f5633e3

$@ugifractal$

permission change

1299248

$@ugifractal$

supress labeler

be570d5

$@ugifractal$

Merge remote-tracking branch 'upstream/main' into ci-fixes

4c59f61

$@ugifractal$

Use incremental fixes

b758e01

$@ugifractal$

Selective linter

d3fcee9

$@ugifractal$

Fix linter

040bf1e

$@ugifractal$

run pre-commit

1188d45

$@ugifractal$

Merge branch 'ci-fixes' into 11ty-build-check

ee7f268

github-actions bot added documentation Improvements or additions to documentation ci dependencies Pull requests that update a dependency file infra frontend labels Sep 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ignore generated assets folder #751

ignore generated assets folder #751

Uh oh!

$@ugifractal$ ugifractal commented Sep 20, 2025

Uh oh!

gemini-code-assist bot commented Sep 20, 2025

Uh oh!

deepsource-io bot commented Sep 20, 2025 •

edited

Loading

Analysis Summary

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 20, 2025

Uh oh!

socket-security bot commented Sep 22, 2025

Uh oh!

Uh oh!

Uh oh!

ignore generated assets folder #751

Are you sure you want to change the base?

ignore generated assets folder #751

Uh oh!

Conversation

ugifractal commented Sep 20, 2025

Uh oh!

gemini-code-assist bot commented Sep 20, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

deepsource-io bot commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Analysis Summary

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Sep 22, 2025

Uh oh!

Uh oh!

$@ugifractal$ ugifractal commented Sep 20, 2025

deepsource-io bot commented Sep 20, 2025 •

edited

Loading