ignore generated assets folder #751

ugifractal · 2025-09-20T02:20:31Z

this PR add ignore for generated assets folder from vite build

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

* Refactor tailwind.css: Change import statement to use URL and reorganize hover effect styles * Refactor role styles in tailwind.css: Consolidate border and color properties for roles * Fix import statement and clean up whitespace in tailwind.css

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

* Natural language fixes in Markdown files * Update DEVELOPER_HELP.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

…ess#590)

) * Format base.njk with Prettier and run pre-commit hooks * Optimize PNGs via pre-commit (oxipng) * Unchanged package-lock.json and package.json * Removed Cdn * Apply pre-commit autofixes (EOF newline, oxipng) * Update frontend/_includes/layouts/base.njk --------- Co-authored-by: John Bampton <[email protected]>

* Create .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update .deepsource.toml

* Update .deepsource.toml * Update .deepsource.toml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Validate codecov.yml file with curl * Fix up

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

…cialchess#712)

)

socket-security · 2025-09-22T12:43:46Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@cloudflare/vitest-pool-workers@0.8.69
	vitest@3.2.4
	wrangler@4.33.2

View full report

jbampton · 2025-09-23T23:53:08Z

Please resolve the conflicts

jbampton · 2025-09-23T23:53:57Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces several valuable improvements, including adding ignore files for generated assets, setting up CSS linting with Stylelint, and refactoring the Dockerfile for multi-architecture support and better security. My review focuses on a few areas to further enhance these changes: I've identified a bug in the updated README.md instructions, along with opportunities to simplify the Dockerfile and clean up some redundant CSS. Overall, this is a solid contribution to improving the project's development workflow and code quality.

gemini-code-assist · 2025-09-23T23:55:58Z

README.md

-docker build -t my-go-precommit .
+mkdir docker_data
+docker buildx build --platform=linux/arm64 -t ubuntu-pre-commit .
+docker run --platform=linux/arm64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash


The volume mount path for the pre-commit and npm caches is incorrect. The Dockerfile now runs as the appuser with /home/appuser as its home directory, but this command attempts to mount the cache to /root/.... This will cause the caching to fail. The path inside the container should be updated to point to the appuser's home directory.

Suggested change

docker run --platform=linux/arm64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash

docker run --platform=linux/arm64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/home/appuser/.cache/pre-commit -v "$PWD/docker_data/.npm":/home/appuser/.npm -w /app ubuntu-pre-commit:latest bash

gemini-code-assist · 2025-09-23T23:55:58Z

README.md

-docker run --platform=linux/amd64 --rm -v "$PWD":/app -w /app my-go-precommit
+mkdir docker_data
+docker buildx build --platform=linux/amd64 -t ubuntu-pre-commit .
+docker run --platform=linux/amd64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash


Similar to the arm64 command, the volume mount path for the amd64 architecture is incorrect. It should point to /home/appuser instead of /root to align with the non-root user configured in the Dockerfile. This fix is necessary for the caching to work as expected.

Suggested change

docker run --platform=linux/amd64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash

docker run --platform=linux/amd64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/home/appuser/.cache/pre-commit -v "$PWD/docker_data/.npm":/home/appuser/.npm -w /app ubuntu-pre-commit:latest bash

gemini-code-assist · 2025-09-23T23:55:58Z

Dockerfile

+RUN curl -LO https://mirrors.aliyun.com/golang/go${GO_VERSION}.linux-${TARGETARCH}.tar.gz && \
+    tar -C /usr/local -xzf go${GO_VERSION}.linux-${TARGETARCH}.tar.gz && \
+    rm go${GO_VERSION}.linux-${TARGETARCH}.tar.gz


Using a specific regional mirror like mirrors.aliyun.com for downloading Go can be slow or unreliable for developers in other parts of the world. It's better to use the official download URL (https://go.dev/dl/) to ensure consistent and reliable access for all contributors. This also avoids tying the build process to a third-party mirror that might change or become unavailable.

RUN curl -LO https://go.dev/dl/go${GO_VERSION}.linux-${TARGETARCH}.tar.gz && \ tar -C /usr/local -xzf go${GO_VERSION}.linux-${TARGETARCH}.tar.gz && \ rm go${GO_VERSION}.linux-${TARGETARCH}.tar.gz

Dockerfile

gemini-code-assist · 2025-09-23T23:55:59Z

frontend/assets/styles/gh-fork-ribbon.css

+	background-image: -webkit-gradient(linear, left top, left bottom, from(rgb(0 0 0 / 0%)), to(rgb(0 0 0 / 15%)));
+	background-image: linear-gradient(to top, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));
+	background-image: linear-gradient(to top, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));
+	background-image: linear-gradient(to top, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));
+	background-image: linear-gradient(to top, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));
+	background-image: linear-gradient(to bottom, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));


There are multiple background-image declarations here, some of which are duplicates or use outdated syntax. You can simplify this by keeping only the modern, standard linear-gradient property. The original vendor-prefixed properties were all equivalent to to bottom, so the to top versions appear to be a mistake.

background-image: linear-gradient(to bottom, rgb(0 0 0 / 0%), rgb(0 0 0 / 15%));

jbampton · 2025-09-25T12:11:32Z

.github/workflows/super-linter.yml

          DEFAULT_BRANCH: main
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          PYTHON_PYLINT_CONFIG_FILE: .pylintrc
-          VALIDATE_ALL_CODEBASE: true


Please don't change this

$ugifractal$

ugifractal and others added 30 commits September 4, 2025 21:17

$@ugifractal$

Use latest ubuntu

7824584

$@ugifractal$

Use target arch

e945335

$@ugifractal$

Increase nvm version

2f06760

Merge branch 'main' into improve-docker-pre-commit

3b5008f

$@ugifractal$

Fix run layers

805ab58

Merge branch 'main' into improve-docker-pre-commit

682dc26

$@ugifractal$

* Fix Dockerfile with separate user

abdd5a6

* Fix CHECKOV Docker security issues (brisbanesocialchess#554) * Update Dockerfile update the code * Update Dockerfile --------- Co-authored-by: John Bampton <[email protected]>

$@ugifractal$

Fix 404 not found page (brisbanesocialchess#578)

42858f4

$@ugifractal$

Remove duplicate npm-ci hook; refactor local hooks (brisbanesocialche…

fd7ef14

…ss#580) * Remove duplicate npm-ci hook; refactor local hooks * Update .pre-commit-config.yaml

$@ugifractal$

Update prettierignore and run (brisbanesocialchess#582)

7cd1e44

$@ugifractal$

pre-commit prettier check JS files (brisbanesocialchess#587)

03574fb

* pre-commit prettier check JS files JS files were not being checked so there was a difference when running pre-commit and prettier manually via `npm run format`

$@ugifractal$

Add eslint ignore for the Sphinx doc folder (brisbanesocialchess#589)

7719163

$@ugifractal$

Update README.md add Cloudflare Pages status button (brisbanesocialch…

743e0c2

…ess#590)

$@ugifractal$

Update README.md fix read the docs button link (brisbanesocialchess#591)

a8a234b

$@ugifractal$

Update .deepsource.toml (brisbanesocialchess#600)

7cc995b

* Update .deepsource.toml

$@ugifractal$

Fix conflict

fe40d3e

$@ugifractal$

add pipefail

ea48ec0

$@ugifractal$

add version

7a41cc7

$@ugifractal$

add --no-cache

d9db89f

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

4c6ba1c

$@ugifractal$

Merge branch 'main' into improve-docker-pre-commit

e177dbd

$@ugifractal$

Validate codecov.yml file with curl (brisbanesocialchess#710)

2b46e57

* Validate codecov.yml file with curl * Fix up

$@ugifractal$

Test Docker with GitHub Actions (brisbanesocialchess#711)

6b58c14

* Test Docker with GitHub Actions * Update .github/workflows/docker-ci.yml

$@ugifractal$

Update dprint.yml add name key with emoji value and title (brisbaneso…

39080eb

…cialchess#712)

$@ugifractal$

Update codecov.yml set require_changes: false (brisbanesocialchess#714

81e2d86

)

ugifractal added 5 commits September 22, 2025 12:41

$@ugifractal$

Fix linter

040bf1e

$@ugifractal$

run pre-commit

1188d45

$@ugifractal$

Merge remote-tracking branch 'upstream/main' into fix-style-lint

2ea8554

$@ugifractal$

Merge branch 'ci-fixes' into fix-style-lint

2b88496

$@ugifractal$

Merge branch 'ci-fixes' into 11ty-build-check

ee7f268

github-actions bot added documentation Improvements or additions to documentation ci dependencies Pull requests that update a dependency file infra frontend labels Sep 22, 2025

$@ugifractal$

Merge branch 'ci-fixes' into improve-docker-pre-commit

d8ca4c5

jbampton self-assigned this Sep 23, 2025

jbampton added this to Chess Sep 23, 2025

jbampton added this to the September milestone Sep 23, 2025

jbampton added the GitHub Sponsors $5 label Sep 23, 2025

jbampton moved this to In Progress in Chess Sep 23, 2025

gemini-code-assist bot reviewed Sep 23, 2025

View reviewed changes

ugifractal added 6 commits September 24, 2025 08:31

$@ugifractal$

Change golang source

561cfa2

$@ugifractal$

Merge branch 'improve-docker-pre-commit' into 11ty-build-check

5d0a26f

$@ugifractal$

fix duplicate

dfff502

$@ugifractal$

Merge branch 'fix-style-lint' into 11ty-build-check

2e50054

$@ugifractal$

fix conflict

d0d1116

$@ugifractal$

remove generated tailwind

95ecc2e

jbampton reviewed Sep 25, 2025

View reviewed changes

$@ugifractal$ ugifractal closed this Sep 25, 2025

github-project-automation bot moved this from In Progress to Done in Chess Sep 25, 2025

jbampton removed the GitHub Sponsors $5 label Sep 26, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ignore generated assets folder #751

ignore generated assets folder #751

Uh oh!

$@ugifractal$ ugifractal commented Sep 20, 2025

Uh oh!

socket-security bot commented Sep 22, 2025 •

edited

Loading

Uh oh!

jbampton commented Sep 23, 2025

Uh oh!

jbampton commented Sep 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Sep 23, 2025

Uh oh!

gemini-code-assist bot Sep 23, 2025

Uh oh!

gemini-code-assist bot Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Sep 23, 2025

Uh oh!

jbampton Sep 25, 2025

Uh oh!

Uh oh!

	docker run --platform=linux/arm64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash
	docker run --platform=linux/arm64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/home/appuser/.cache/pre-commit -v "$PWD/docker_data/.npm":/home/appuser/.npm -w /app ubuntu-pre-commit:latest bash

	docker run --platform=linux/amd64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/root/.cache/pre-commit -v "$PWD/docker_data/.npm":/root/.npm -w /app ubuntu-pre-commit:latest bash
	docker run --platform=linux/amd64 -it -v "$PWD":/app -v "$PWD/docker_data/.cache/pre-commit":/home/appuser/.cache/pre-commit -v "$PWD/docker_data/.npm":/home/appuser/.npm -w /app ubuntu-pre-commit:latest bash

Uh oh!

ignore generated assets folder #751

ignore generated assets folder #751

Uh oh!

Conversation

ugifractal commented Sep 20, 2025

Uh oh!

socket-security bot commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbampton commented Sep 23, 2025

Uh oh!

jbampton commented Sep 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Sep 23, 2025

Choose a reason for hiding this comment

Uh oh!

jbampton Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

$@ugifractal$ ugifractal commented Sep 20, 2025

socket-security bot commented Sep 22, 2025 •

edited

Loading