Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix world_to_window #65

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix world_to_window #65

merged 2 commits into from
Jan 22, 2024

Conversation

NaakkaDev
Copy link
Contributor

@NaakkaDev NaakkaDev commented Jan 13, 2024 •
edited
Loading

Fixes orthographic/camera.lua:795: attempt to index a nil value when using camera.world_to_window(nil, go.get_position("foo")).

Issue #63 can probably be closed too.

britzl
britzl requested changes Jan 20, 2024
View reviewed changes
Copy link
Owner

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please add a comment about passing nil to get the first camera (see other functions for reference)

@NaakkaDev NaakkaDev requested a review from britzl January 22, 2024 09:27
britzl
britzl approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@britzl britzl merged commit 3fdeb0e into britzl:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britzl britzl britzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NaakkaDev @britzl