Context Explorer v2 changes #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acameron13
commented
Mar 4, 2025
acameron13
commented
- Adding subtype tree and context matrix creation to the data-prep-pipeline
- Editing the get_context_analysis script to return results for all new contexts
…ll levels and all types
…e sure I didn't miss anything
alimourey
reviewed
Mar 5, 2025
| args.subtype_tree | ||
| ) | ||
|
|
||
| if context_matrix is not None: |
There was a problem hiding this comment.
Is there ever a case where the context matrix being None isn't a gigantic problem? If None is not an acceptable result, should we just let this blow up here so we're aware sooner?
alimourey
reviewed
Mar 5, 2025
| ''' | ||
|
|
||
| #sorting by full subtype name is important so that the level and parent | ||
| #assignments don't get jumbled |
There was a problem hiding this comment.
I don't think I understand what this comment means. Do you have an example of what the level and parent assignments getting jumbled looks like?
There was a problem hiding this comment.
Just added a more in-depth explanation of what I mean!
alimourey
reviewed
Mar 5, 2025
| ) | ||
|
|
||
| if subtype_tree is not None: | ||
| subtype_tree.to_csv(args.output) |
There was a problem hiding this comment.
Like above, I wonder if we should take out this None check. Maybe I'm misunderstanding how this works.
…and causing problems early if things aren't right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.