-
Notifications
You must be signed in to change notification settings - Fork 77
Enable passing a threshold to govern the window for detection of dispersed deletions #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mwalker174 One thing to note here - default for this is currently 1000000 to match what's currently in GATK-SV, let me know if you think I should reduce this though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks ok, and let's set the threshold to 5000 as discussed offline
Retested with updated default, merging now. |
@@ -132,6 +132,7 @@ workflows: | |||
filters: | |||
branches: | |||
- main | |||
- kj_cpx_cutoff_modification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjaisingh please undo this in another PR; no need to have a PR only for this, it can go as part of an existing PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Vahid, thanks for pointing this out - yes, I made #866 in light of this, but will include it in another PR if I merge one soon. Apologies for the inconvenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I would remove it as part of one of your relevant PRs.
Description
This PR is intended to enable passing in a custom breakpoint cutoff for dispersed duplication detection for complex events in GATK-SV. It also sets this cutoff as 5000 by default, as opposed to 1000000 in the existing implementation.
Testing
1000000
passed - the number of variants in the output VCF is equal to the original case.CPX_TYPE
ofdupINV
are revised todDUP
.womtool
.Pre-Merge Changes Required
Remove automated sync of the
GenotypeComplexVariants
WDL to Dockstore.